Bugzilla – Attachment 124703 Details for
Bug 28772
Any user that can work with reports can see API keys of any other user
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28772: (QA follow-up) Fix wrong message
Bug-28772-QA-follow-up-Fix-wrong-message.patch (text/plain), 1.03 KB, created by
Marcel de Rooy
on 2021-09-09 12:47:23 UTC
(
hide
)
Description:
Bug 28772: (QA follow-up) Fix wrong message
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-09-09 12:47:23 UTC
Size:
1.03 KB
patch
obsolete
>From 55b8d72d9b03cfbe8f5bf15e4564fc2408114c1f Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 9 Sep 2021 08:53:07 -0300 >Subject: [PATCH] Bug 28772: (QA follow-up) Fix wrong message >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/ApiKey.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/ApiKey.t b/t/db_dependent/Koha/ApiKey.t >index 4ba0861f0e..228f0961c9 100755 >--- a/t/db_dependent/Koha/ApiKey.t >+++ b/t/db_dependent/Koha/ApiKey.t >@@ -131,7 +131,7 @@ subtest 'validate_secret() tests' => sub { > my $secret = $api_key->plain_text_secret; > > ok( $api_key->validate_secret( $secret ), 'Valid secret returns true' ); >- ok( !$api_key->validate_secret( 'Wrong secret' ), 'Invalid secret returns true' ); >+ ok( !$api_key->validate_secret( 'Wrong secret' ), 'Invalid secret returns false' ); > > $schema->storage->txn_rollback; > }; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28772
:
124195
|
124247
|
124248
|
124249
|
124250
|
124251
|
124487
|
124488
|
124489
|
124490
|
124491
|
124691
|
124692
|
124693
|
124694
|
124695
|
124696
|
124697
|
124698
|
124699
|
124700
|
124701
|
124702
| 124703 |
124704
|
124705
|
124727
|
125088
|
125112
|
125116
|
125118
|
125128