Attachment 124723 Details for Bug 28464 – Bug 28464: Remove useless check that gives the incorrect error message

[patch] Bug 28464: Remove useless check that gives the incorrect error message

Bug-28464-Remove-useless-check-that-gives-the-inco.patch (text/plain), 1.15 KB, created by Marcel de Rooy on 2021-09-10 07:24:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-09-10 07:24:22 UTC

Size: 1.15 KB

patch

obsolete

>From 14695b1edd8dd8e9336fbd75946d34ef0c0a799c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 26 May 2021 11:16:13 -0400
>Subject: [PATCH] Bug 28464: Remove useless check that gives the incorrect
> error message
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/SIP/ILS.pm | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm
>index 3cacc3aa44..145fe89aac 100644
>--- a/C4/SIP/ILS.pm
>+++ b/C4/SIP/ILS.pm
>@@ -355,13 +355,7 @@ sub cancel_hold {
> 		return $trans;
> 	}
>     # Remove the hold from the patron's record first
>-    $trans->ok($patron->drop_hold($item_id));	# different than the transaction drop!
>-
>-    unless ($trans->ok) {
>-		# We didn't find it on the patron record
>-		$trans->screen_msg("No such hold on patron record.");
>-		return $trans;
>-    }
>+    $patron->drop_hold($item_id); # different than the transaction drop!
> 
>     # Now, remove it from the item record.  If it was on the patron
>     # record but not on the item record, we'll treat that as success.
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28464: 121437 | 121438 | 122199 | 122200 | 124722 | 124723 | 124724