Attachment 124725 Details for Bug 28946 – Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl

[patch] Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl

Bug-28946-bug-23271-follow-up-Missing-occurrence-i.patch (text/plain), 1.64 KB, created by Jonathan Druart on 2021-09-10 08:07:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-09-10 08:07:45 UTC

Size: 1.64 KB

patch

obsolete

>From 60b7b01e9d713814a89a7896b14bc654ea6b61d0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 10 Sep 2021 10:03:05 +0200
>Subject: [PATCH] Bug 28946: (bug 23271 follow-up) Missing occurrence in
> add_user_search.pl
>
>commit f6e0b04f48e8f0a02dbb8d48152646257d9accba
>Bug 23271: Replace search_limited with search_with_library_limits
>
>We were modifying the occurrences of:
>  Koha::Patron::Categories->search_limited;
>with:
>  Koha::Patron::Categories->search_with_library_limits;
>
>But between the patch submission and the push, another occurrence has
>been added by bug 23590.
>
>Test plan:
>Create a new suggestion from staff and click "select manager"
>Without the patch, notice the error:
>  The method Koha::Patron::Categories->search_limited is not covered by tests!
>With the patch applied everything is working correctly
>---
> suggestion/add_user_search.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/suggestion/add_user_search.pl b/suggestion/add_user_search.pl
>index d4b5ff02434..d71d033f0e6 100755
>--- a/suggestion/add_user_search.pl
>+++ b/suggestion/add_user_search.pl
>@@ -49,7 +49,7 @@ my $search_patrons_with_suggestion_perm_only =
>     ( $permissions && $permissions eq 'suggestions.suggestions_manage' )
>         ? 1 : 0;
> 
>-my $patron_categories = Koha::Patron::Categories->search_limited;
>+my $patron_categories = Koha::Patron::Categories->search_with_library_limits({}, {order_by => ['description']});;
> $template->param(
>     patrons_with_suggestion_perm_only => $search_patrons_with_suggestion_perm_only,
>     view => ( $input->request_method() eq "GET" ) ? "show_form" : "show_results",
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28946: 124725 | 124751