Bugzilla – Attachment 124769 Details for
Bug 28935
No filtering on patron's data on member entry pages (OPAC, self registration, staff interface)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28935: No filtering on patron's data on member entry pages [SIMPLE]
Bug-28935-No-filtering-on-patrons-data-on-member-e.patch (text/plain), 2.59 KB, created by
Marcel de Rooy
on 2021-09-10 15:18:50 UTC
(
hide
)
Description:
Bug 28935: No filtering on patron's data on member entry pages [SIMPLE]
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-09-10 15:18:50 UTC
Size:
2.59 KB
patch
obsolete
>From 466f1c075edd5359b0d7bbc4b6a9f1dcc8305ea0 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 1 Sep 2021 16:04:31 +0200 >Subject: [PATCH] Bug 28935: No filtering on patron's data on member entry > pages >Content-Type: text/plain; charset=utf-8 > >Security patch. Follow-up for 28929. Backported minimalistically. >Including correction for gonenoaddress and two others. >--- > members/memberentry.pl | 4 ++-- > opac/opac-memberentry.pl | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index c9460583af..6bd6161e5c 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -215,7 +215,7 @@ if ( $op eq 'insert' || $op eq 'modify' || $op eq 'save' || $op eq 'duplicate' ) > # remove keys from %newdata that is not part of patron's attributes > { > my @keys_to_delete = ( >- qr/^flags$/, >+ qr/^(borrowernumber|date_renewed|debarred|debarredcomment|flags|privacy|privacy_guarantor_fines|privacy_guarantor_checkouts|checkprevcheckout|updated_on|lastseen|lang|login_attempts|overdrive_auth_token|anonymized)$/, # Bug 28935 > qr/^BorrowerMandatoryField$/, > qr/^category_type$/, > qr/^check_member$/, >@@ -323,7 +323,7 @@ if ($op eq 'save' || $op eq 'insert'){ > # If the cardnumber is blank, treat it as null. > $newdata{'cardnumber'} = undef if $newdata{'cardnumber'} =~ /^\s*$/; > >- if (my $error_code = checkcardnumber($newdata{cardnumber},$newdata{borrowernumber})){ >+ if (my $error_code = checkcardnumber( $newdata{cardnumber}, $borrowernumber )){ > push @errors, $error_code == 1 > ? 'ERROR_cardnumber_already_exists' > : $error_code == 2 >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index c940a6e1af..34f13a3e27 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -522,7 +522,9 @@ sub ParseCgiForBorrower { > # Replace checkbox 'agreed' by datetime in gdpr_proc_consent > $borrower{gdpr_proc_consent} = dt_from_string if $borrower{gdpr_proc_consent} && $borrower{gdpr_proc_consent} eq 'agreed'; > >- delete $borrower{flags}; >+ delete $borrower{$_} for qw/borrowernumber date_renewed debarred debarredcomment flags privacy privacy_guarantor_fines privacy_guarantor_checkouts checkprevcheckout updated_on lastseen lang login_attempts overdrive_auth_token anonymized/; # See also members/memberentry.pl >+ delete $borrower{$_} for qw/dateenrolled dateexpiry borrowernotes opacnote sort1 sort2 sms_provider_id autorenew_checkouts gonenoaddress lost relationship/; # On OPAC only >+ > return %borrower; > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28935
:
124326
|
124327
|
124350
|
124416
|
124418
|
124422
|
124425
|
124446
|
124447
|
124448
|
124449
|
124450
|
124461
|
124462
|
124499
|
124500
|
124501
|
124502
|
124503
|
124523
|
124524
|
124525
|
124526
|
124527
|
124528
|
124529
|
124530
|
124531
|
124532
|
124640
|
124641
|
124642
|
124643
|
124644
|
124645
|
124646
|
124647
|
124648
|
124649
|
124650
|
124730
|
124731
|
124732
|
124733
|
124734
|
124735
|
124736
|
124737
|
124738
|
124739
|
124740
|
124769
|
124784
|
124832
|
124833
|
124837
|
124838
|
124839
|
124840