Attachment 124884 Details for Bug 29026 – Bug 29026: Restore behavior when an empty barcode field is submitted in circulation

[patch] Bug 29026: Restore behavior when an empty barcode field is submitted in circulation

Bug-29026-Restore-behavior-when-an-empty-barcode-f.patch (text/plain), 2.58 KB, created by Kyle M Hall (khall) on 2021-09-15 12:29:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-09-15 12:29:22 UTC

Size: 2.58 KB

patch

obsolete

>From 40cbae22c95e9782758394a4d6a10351aa704d0d Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 14 Sep 2021 21:33:47 -1000
>Subject: [PATCH] Bug 29026: Restore behavior when an empty barcode field is
> submitted in circulation
>
>When preference CircAutoPrintQuickSlip is 'clear the screen', when an empty barcode field is submitted in circulation :
>
>Before Bug 17845, behavior was to display empty circulation page (no patron selected).
>Now behavior is displaying the circulation page of current patron.
>
>I think previous behavior was used when scanner is used to clear form and wait for another patron card to be scanned.
>
>Test plan :
>1) Set system preference CircAutoPrintQuickSlip to 'clear the screen'
>2) Go to a patron circulation page
>3) Post form without a barcode
>=> Check you go to circulation page with no patron selected
>4) Set system preference CircAutoPrintQuickSlip to 'open a print quick slip window'
>5) Go to a patron circulation page
>6) Post form without a barcode
>=> Check you go to print quick slip window with correct datas
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/modules/circ/circulation.tt         | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 6e7aa020de..ae83cd95a1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -1051,14 +1051,17 @@
>                 });
>             }
> 
>-            [% IF !( CircAutoPrintQuickSlip == 'clear' ) %]
>-                // listen submit to trigger qslip on empty checkout
>-                $('#mainform').bind('submit',function() {
>-                    if ($('#barcode').val() == '') {
>+            // listen submit to trigger qslip on empty checkout
>+            $('#mainform').bind('submit',function() {
>+                if ($('#barcode').val() == '') {
>+                    [% IF ( CircAutoPrintQuickSlip == 'clear' ) %]
>+                        window.location='/cgi-bin/koha/circ/circulation.pl';
>+                        return false;
>+                    [% ELSE %]
>                         return printx_window( '[% CircAutoPrintQuickSlip | html %]' );
>-                    }
>-                });
>-            [% END %]
>+                    [% END %]
>+                }
>+            });
>             toggle_onsite_checkout();
>             $("#onsite_checkout").click(function(){
>                 toggle_onsite_checkout();
>-- 
>2.30.1 (Apple Git-130)

Actions: View | Diff | Splinter Review

Attachments on bug 29026: 124877 | 124884 | 125338