Attachment 124897 Details for Bug 29029 – Bug 29029: Introduce Koha::Object::ColumnSet

[patch] Bug 29029: Introduce Koha::Object::ColumnSet

Bug-29029-Introduce-KohaObjectColumnSet.patch (text/plain), 4.87 KB, created by Marcel de Rooy on 2021-09-15 14:58:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-09-15 14:58:56 UTC

Size: 4.87 KB

patch

obsolete

>From 3dc982ba678306b6a557cfab0d5945379dbf31bc Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 13 Sep 2021 08:05:11 +0000
>Subject: [PATCH] Bug 29029: Introduce Koha::Object::ColumnSet
>Content-Type: text/plain; charset=utf-8
>
>---
> Koha/Object.pm           |  26 ++++++++++
> Koha/Object/ColumnSet.pm | 106 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 132 insertions(+)
> create mode 100644 Koha/Object/ColumnSet.pm
>
>diff --git a/Koha/Object.pm b/Koha/Object.pm
>index 6f55c3b486..20f9530a26 100644
>--- a/Koha/Object.pm
>+++ b/Koha/Object.pm
>@@ -29,6 +29,7 @@ use Koha::Database;
> use Koha::Exceptions::Object;
> use Koha::DateUtils qw( dt_from_string output_pref );
> use Koha::Object::Message;
>+use Koha::Object::ColumnSet;
> 
> =head1 NAME
> 
>@@ -784,6 +785,31 @@ sub _columns {
>     return $self->{_columns};
> }
> 
>+=head3 filter
>+
>+    my $some_columns = $self->filter({ column_set => $column_set_name });
>+
>+    Filters the object data through the specified column set (defined in
>+    schema file).
>+    Allows filtering other input (hashref) by including input => $input.
>+    When you pass deny_mode => 1, the column set is used as a deny list.
>+    Normally, it is considered as an allow list.
>+    Diagnostics via dump => $dump, logging via log_level => $log_level.
>+    Note: $dump contains the blocked/discarded entries.
>+    Log level is debug, warn, etc.
>+
>+=cut
>+
>+sub filter {
>+    my ( $self, $params ) = @_;
>+    my $set = Koha::Object::ColumnSet->new({ rs => $self->_result, name => $params->{column_set} });
>+    return $set->apply_filter({ input => $params->{input}, deny_mode => $params->{deny_mode}, log_level => $params->{log_level}, dump => $params->{dump} });
>+}
>+
>+=head3 _get_object_class
>+
>+=cut
>+
> sub _get_object_class {
>     my ( $type ) = @_;
>     return unless $type;
>diff --git a/Koha/Object/ColumnSet.pm b/Koha/Object/ColumnSet.pm
>new file mode 100644
>index 0000000000..2dd7f0180a
>--- /dev/null
>+++ b/Koha/Object/ColumnSet.pm
>@@ -0,0 +1,106 @@
>+package Koha::Object::ColumnSet;
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+use Carp ();
>+use Data::Dumper ();
>+
>+use Koha::Logger ();
>+
>+=head1 NAME
>+
>+Koha::Object::ColumnSet
>+
>+=head1 API
>+
>+=head2 Class Methods
>+
>+=head3 new
>+
>+    Constructor.
>+
>+=cut
>+
>+sub new {
>+    my ( $class, $params ) = @_; # parameter hash keys: rs, name
>+    my $self = bless( $params, $class );
>+    $self->_get_column_set;
>+    return $self;
>+}
>+
>+sub _get_column_set {
>+    my ( $self ) = @_;
>+    my $rs = $self->{rs} or return;
>+    my $name = $self->{name} or return;
>+
>+    # We assume now that the caller of apply_filter knows about get_column_set
>+    $self->{_list} = [];
>+    if( $rs->can('get_column_set') ) {
>+        my $list = $rs->get_column_set($name);
>+        $self->{_list} = $list if ref($list) eq 'ARRAY';
>+    }
>+}
>+
>+=head3 apply_filter
>+
>+    $set->apply_filter({ input => $input, deny_mode => $deny_mode, log_level => $log_level, dump => $dump });
>+
>+    Apply column set filter to $input or the passed resultset (see new).
>+    $deny_mode turns the column set into a deny list.
>+    Diagnostics and logging via $dump and $log_level.
>+
>+=cut
>+
>+sub apply_filter {
>+    my ( $self, $params ) = @_;
>+    my $data = $params->{input} // { $self->{rs}->get_columns };
>+    my $log_level = $params->{log_level};
>+
>+    my ( $result, $blocked );
>+    unless( $params->{deny_mode} ) { # as allow list
>+        $result = { map { exists $data->{$_} ? ($_, $data->{$_}) : () } @{$self->{_list}} };
>+    } else { # as deny list
>+        $result = { %$data };
>+        map { delete $result->{$_} } @{$self->{_list}};
>+    }
>+
>+    # Handle optional diagnostics, logging
>+    if( $params->{dump} || $log_level ) {
>+        $blocked = { map { !exists $result->{$_} ? ($_, $data->{$_}) : () } keys %$data };
>+        map { $params->{dump}->{$_} = $blocked->{$_} } keys %$blocked if $params->{dump};
>+        if( $log_level && keys %$blocked ) {
>+            my $stack = Carp::longmess; $stack =~ s/\n/, /g;
>+            my $diag = Data::Dumper->new([ $stack, $blocked ])->Indent(0)->Dump;
>+            Koha::Logger->get->$log_level( $diag );
>+        }
>+    }
>+
>+    return $result;
>+}
>+
>+=head3 list_columns
>+
>+    $set->list_columns
>+
>+=cut
>+
>+sub list_columns {
>+    my ( $self ) = @_;
>+    return [ sort @{$self->{_list}} ];
>+}
>+
>+1;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29029: 124885 | 124897 | 124898