Attachment 124970 Details for Bug 27944 – Bug 27944: (follow-up) Improving consistency between notice names

[patch] Bug 27944: (follow-up) Improving consistency between notice names

Bug-27944-follow-up-Improving-consistency-between-.patch (text/plain), 3.48 KB, created by Nick Clemens (kidclamp) on 2021-09-17 11:10:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-09-17 11:10:22 UTC

Size: 3.48 KB

patch

obsolete

>From 033bba7d55dbed17b3bbb53061da104f38c9028c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 14 Jul 2021 14:42:30 +0000
>Subject: [PATCH] Bug 27944: (follow-up) Improving consistency between notice
> names
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> installer/data/mysql/atomicupdate/bug_27944.perl     | 4 ++--
> installer/data/mysql/en/mandatory/sample_notices.yml | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_27944.perl b/installer/data/mysql/atomicupdate/bug_27944.perl
>index 89e004d753..bc6489fd78 100644
>--- a/installer/data/mysql/atomicupdate/bug_27944.perl
>+++ b/installer/data/mysql/atomicupdate/bug_27944.perl
>@@ -10,7 +10,7 @@ if ( CheckVersion($DBversion) ) {
>         q{
>         UPDATE  `letter`
>         SET     `code` = 'AR_REQUESTED',
>-                `name` = 'Article requested'
>+                `name` = REPLACE(name, '- open', '- new')
>         WHERE   `module` = 'circulation'
>                 AND `code` = 'AR_PENDING'
>     }
>@@ -19,7 +19,7 @@ if ( CheckVersion($DBversion) ) {
>     $dbh->do(
>         q{
>         INSERT IGNORE INTO `letter` (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`) VALUES
>-        ('circulation', 'AR_PENDING', '', 'Article request - open', 0, 'Pending article request', 'Dear <<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nYour request for an article from <<biblio.title>> (<<items.barcode>>) is now in pending state.\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\nNotes: <<article_requests.patron_notes>>\r\n\r\n\r\nThank you!', 'email')
>+        ('circulation', 'AR_PENDING', '', 'Article request - pending', 0, 'Pending article request', 'Dear <<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>)\r\n\r\nYour request for an article from <<biblio.title>> (<<items.barcode>>) is now in pending state.\r\n\r\nArticle requested:\r\nTitle: <<article_requests.title>>\r\nAuthor: <<article_requests.author>>\r\nVolume: <<article_requests.volume>>\r\nIssue: <<article_requests.issue>>\r\nDate: <<article_requests.date>>\r\nPages: <<article_requests.pages>>\r\nChapters: <<article_requests.chapters>>\r\nNotes: <<article_requests.patron_notes>>\r\n\r\n\r\nThank you!', 'email')
>     }
>     );
> 
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 5ebe582288..ffecef82c9 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -278,7 +278,7 @@ tables:
>         - module: circulation
>           code: AR_PENDING
>           branchcode: ""
>-          name: "Article request - open"
>+          name: "Article request - pending"
>           is_html: 0
>           title: "Pending article request"
>           message_transport_type: email
>@@ -304,7 +304,7 @@ tables:
>         - module: circulation
>           code: AR_REQUESTED
>           branchcode: ""
>-          name: "Article requested"
>+          name: "Article request - new"
>           is_html: 0
>           title: "Article request received"
>           message_transport_type: email
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27944: 119020 | 119021 | 119022 | 120454 | 122673 | 122836 | 122837 | 122838 | 122839 | 122842 | 122843 | 122857 | 122984 | 122985 | 122986 | 122987 | 122988 | 122989 | 122990 | 123710 | 123711 | 123712 | 123943 | 123944 | 123945 | 123946 | 123947 | 123948 | 123949 | 123950 | 123951 | 123952 | 124966 | 124967 | 124968 | 124969 | 124970 | 124971 | 124972 | 124973 | 124974 | 124975 | 124976 | 125158 | 125544 | 125565 | 125567 | 125762 | 125813