Attachment 124971 Details for Bug 27944 – Bug 27944: (follow-up) Move existing statuses, rename idempotent

[patch] Bug 27944: (follow-up) Move existing statuses, rename idempotent

Bug-27944-follow-up-Move-existing-statuses-rename-.patch (text/plain), 1.38 KB, created by Nick Clemens (kidclamp) on 2021-09-17 11:10:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-09-17 11:10:27 UTC

Size: 1.38 KB

patch

obsolete

>From 87d279829befb6909e6da215992af314d909b41f Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 14 Jul 2021 15:01:23 +0000
>Subject: [PATCH] Bug 27944: (follow-up) Move existing statuses, rename
> idempotent
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> installer/data/mysql/atomicupdate/bug_27944.perl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_27944.perl b/installer/data/mysql/atomicupdate/bug_27944.perl
>index bc6489fd78..1d0f2f2b0a 100644
>--- a/installer/data/mysql/atomicupdate/bug_27944.perl
>+++ b/installer/data/mysql/atomicupdate/bug_27944.perl
>@@ -5,6 +5,7 @@ if ( CheckVersion($DBversion) ) {
>     $dbh->do(
> "ALTER TABLE `article_requests` MODIFY `status` enum('REQUESTED', 'PENDING','PROCESSING','COMPLETED','CANCELED') COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'REQUESTED'"
>     );
>+    $dbh->do(q|UPDATE article_requests SET status='REQUESTED' WHERE status='PENDING'|);
> 
>     $dbh->do(
>         q{
>@@ -14,7 +15,7 @@ if ( CheckVersion($DBversion) ) {
>         WHERE   `module` = 'circulation'
>                 AND `code` = 'AR_PENDING'
>     }
>-    );
>+    ) if ( $dbh->selectrow_array('SELECT COUNT(*) FROM letter WHERE code=?', undef, 'AR_REQUESTED') )[0] == 0; # Check to make idempotent
> 
>     $dbh->do(
>         q{
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27944: 119020 | 119021 | 119022 | 120454 | 122673 | 122836 | 122837 | 122838 | 122839 | 122842 | 122843 | 122857 | 122984 | 122985 | 122986 | 122987 | 122988 | 122989 | 122990 | 123710 | 123711 | 123712 | 123943 | 123944 | 123945 | 123946 | 123947 | 123948 | 123949 | 123950 | 123951 | 123952 | 124966 | 124967 | 124968 | 124969 | 124970 | 124971 | 124972 | 124973 | 124974 | 124975 | 124976 | 125158 | 125544 | 125565 | 125567 | 125762 | 125813