Attachment 124972 Details for Bug 27944 – Bug 27944: (follow-up) Move statuses to constants

[patch] Bug 27944: (follow-up) Move statuses to constants

Bug-27944-follow-up-Move-statuses-to-constants.patch (text/plain), 1.29 KB, created by Nick Clemens (kidclamp) on 2021-09-17 11:10:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-09-17 11:10:33 UTC

Size: 1.29 KB

patch

obsolete

>From c779fe0fb767a5277397ea3063e164d9b37c6150 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 15 Jul 2021 06:13:36 +0000
>Subject: [PATCH] Bug 27944: (follow-up) Move statuses to constants
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/ArticleRequest/Status.pm | 33 ++++++---------------------------
> 1 file changed, 6 insertions(+), 27 deletions(-)
>
>diff --git a/Koha/ArticleRequest/Status.pm b/Koha/ArticleRequest/Status.pm
>index 859e9f4a56..3bd62b7952 100644
>--- a/Koha/ArticleRequest/Status.pm
>+++ b/Koha/ArticleRequest/Status.pm
>@@ -19,37 +19,16 @@ package Koha::ArticleRequest::Status;
> 
> use Modern::Perl;
> 
>+use constant Requested  => 'REQUESTED';
>+use constant Pending    => 'PENDING';
>+use constant Processing => 'PROCESSING';
>+use constant Completed  => 'COMPLETED';
>+use constant Canceled   => 'CANCELED';
>+
> =head1 AUTHOR
> 
> Kyle M Hall <kyle@bywatersolutions.com>
> 
> =cut
> 
>-=head2 Requested
>-
>-    returns constant string 'REQUESTED'
>-
>-=cut
>-
>-sub Requested {
>-    return 'REQUESTED';
>-}
>-
>-sub Pending {
>-    return 'PENDING';
>-}
>-
>-sub Processing {
>-    return 'PROCESSING';
>-}
>-
>-sub Completed {
>-    return 'COMPLETED';
>-}
>-
>-sub Canceled {
>-    return 'CANCELED';
>-}
>-
>-
> 1;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27944: 119020 | 119021 | 119022 | 120454 | 122673 | 122836 | 122837 | 122838 | 122839 | 122842 | 122843 | 122857 | 122984 | 122985 | 122986 | 122987 | 122988 | 122989 | 122990 | 123710 | 123711 | 123712 | 123943 | 123944 | 123945 | 123946 | 123947 | 123948 | 123949 | 123950 | 123951 | 123952 | 124966 | 124967 | 124968 | 124969 | 124970 | 124971 | 124972 | 124973 | 124974 | 124975 | 124976 | 125158 | 125544 | 125565 | 125567 | 125762 | 125813