Attachment 124973 Details for Bug 27944 – Bug 27944: REQUESTED is the new default status

[patch] Bug 27944: REQUESTED is the new default status

Bug-27944-REQUESTED-is-the-new-default-status.patch (text/plain), 1.74 KB, created by Nick Clemens (kidclamp) on 2021-09-17 11:10:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-09-17 11:10:37 UTC

Size: 1.74 KB

patch

obsolete

>From 536cd3c150d83810abc69195c513ebbd482d2521 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 10 Aug 2021 13:11:42 -0300
>Subject: [PATCH] Bug 27944: REQUESTED is the new default status
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> t/db_dependent/ArticleRequests.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/ArticleRequests.t b/t/db_dependent/ArticleRequests.t
>index 3f0ec37cd3..bb4b5f8b8d 100755
>--- a/t/db_dependent/ArticleRequests.t
>+++ b/t/db_dependent/ArticleRequests.t
>@@ -76,13 +76,13 @@ my $article_request = Koha::ArticleRequest->new(
> )->store();
> 
> my $notify_message = Koha::Notice::Messages->search->next;
>-is( $notify_message->letter_code, "AR_".Koha::ArticleRequest::Status::Pending);
>+is( $notify_message->letter_code, "AR_".Koha::ArticleRequest::Status::Requested);
> # Default AR_PROCESSING template content "Title: <<article_requests.title>>"
> like( $notify_message->content, qr{Title: $article_request_title}, 'Values from article_requests table must be fetched for the notification' );
> 
> $article_request = Koha::ArticleRequests->find( $article_request->id );
> ok( $article_request->id, 'Koha::ArticleRequest created' );
>-is( $article_request->status, Koha::ArticleRequest::Status::Pending, 'New article request has status of Open' );
>+is( $article_request->status, Koha::ArticleRequest::Status::Requested, 'New article request has status of Open' );
> isnt( $article_request->created_on, undef, 'New article request has created_on date set' );
> isnt( $article_request->updated_on, undef, 'New article request has updated_on date set' );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27944: 119020 | 119021 | 119022 | 120454 | 122673 | 122836 | 122837 | 122838 | 122839 | 122842 | 122843 | 122857 | 122984 | 122985 | 122986 | 122987 | 122988 | 122989 | 122990 | 123710 | 123711 | 123712 | 123943 | 123944 | 123945 | 123946 | 123947 | 123948 | 123949 | 123950 | 123951 | 123952 | 124966 | 124967 | 124968 | 124969 | 124970 | 124971 | 124972 | 124973 | 124974 | 124975 | 124976 | 125158 | 125544 | 125565 | 125567 | 125762 | 125813