Bugzilla – Attachment 125032 Details for
Bug 28934
OPAC registration form design is not consistent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28934: Make the OPAC registration form design consistent
Bug-28934-Make-the-OPAC-registration-form-design-c.patch (text/plain), 4.07 KB, created by
Joonas Kylmälä
on 2021-09-19 10:27:39 UTC
(
hide
)
Description:
Bug 28934: Make the OPAC registration form design consistent
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-09-19 10:27:39 UTC
Size:
4.07 KB
patch
obsolete
>From 9e39acf87483378ce59eebc1181dc0d2a1f30842 Mon Sep 17 00:00:00 2001 >From: user <user@debian> >Date: Sun, 19 Sep 2021 13:13:22 +0300 >Subject: [PATCH] Bug 28934: Make the OPAC registration form design consistent > >The gender/sex and GDPR inputs were slightly misaligned (by >1.5em). Now they are aligned with the other inputs which have a width >of 10em (9em width + margin 1em). The label assignments and required >attributes for input elements are made also consistent. > >To test: > 1) Enable GDPR_Policy syspref > 2) Apply patch, run "yarn build --view opac", restart plack > 3) Go to /cgi-bin/koha/opac-memberentry.pl > 3) Check that the GDPR input box shows the required text now in red > color > 3) Check that the alignment of sex/gender and GDPR input matches with > the other inputs perfectly. >--- > koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 8 +++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index c665cfea5d..6605f9d258 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -774,7 +774,7 @@ fieldset { > width: 100%; > > &.lradio { >- padding-left: 8.5em; >+ padding-left: 10em; > width: auto; > > label { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 7f1ad4a58a..8f0ccf3078 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -871,11 +871,11 @@ > </div> > > <ol> >- <li><label for="borrower_password" class="[% required.password | html %]">Password</label> >+ <li><label for="password" class="[% required.password | html %]">Password:</label> > <input type="password" name="borrower_password" id="password" class="[% required.password | html %]" /> > <div class="required_label [% required.password | html %]">Required</div> > </li> >- <li><label for="borrower_password2" class="[% required.password | html %]">Confirm password</label> >+ <li><label for="password2" class="[% required.password | html %]">Confirm password:</label> > <input type="password" name="borrower_password2" id="password2" /> > <div class="required_label [% required.password | html %]">Required</div> > </li> >@@ -958,7 +958,9 @@ > <legend>GDPR consent</legend> > <ol> > <li> >- <label></label><span><input type="checkbox" name="borrower_gdpr_proc_consent" value="agreed"> I agree with your processing of my personal data as outlined in the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a>. <div class="required">Required</div></span> >+ <label for="borrower_gdpr_proc_consent">Consent:</label> >+ <span><input type="checkbox" name="borrower_gdpr_proc_consent" id="borrower_gdpr_proc_consent" value="agreed"> I agree with your processing of my personal data as outlined in the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a>.</span> >+ <div class="required_label required">Required</div> > </li> > </ol> > </fieldset> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28934
:
124322
|
124441
|
124830
|
124852
|
125032
|
125117
|
125123
|
125334