Bugzilla – Attachment 125036 Details for
Bug 28906
Koha::Items->filter_by_visible_in_opac doesn't honour list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context
Bug-28906-Make-KohaItems-filterbyvisibleinopac-hon.patch (text/plain), 1018 bytes, created by
David Nind
on 2021-09-19 20:29:59 UTC
(
hide
)
Description:
Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour list context
Filename:
MIME Type:
Creator:
David Nind
Created:
2021-09-19 20:29:59 UTC
Size:
1018 bytes
patch
obsolete
>From 1f6a4e4cc67e08cdfdbdf50b19ffe7c366a36b9a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 26 Aug 2021 09:35:39 -0300 >Subject: [PATCH] Bug 28906: Make Koha::Items->filter_by_visible_in_opac honour > list context > >This patch makes the method honour list context. > >To test: >1. Apply the regression tests patch >2. Run: > $ kshell > k$ prove t/db_dependent/Koha/Items.t >=> FAIL: Tests fail! It returns [Koha::Items]. Boo! >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Tests pass! >5. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Items.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Items.pm b/Koha/Items.pm >index 193e6e58d2..3e2430642e 100644 >--- a/Koha/Items.pm >+++ b/Koha/Items.pm >@@ -91,7 +91,7 @@ sub filter_by_visible_in_opac { > $result = $result->filter_out_lost; > } > >- return $result; >+ return $result->search; > } > > =head3 filter_out_lost >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28906
:
124112
|
124113
|
124114
|
124115
|
125035
|
125036
|
125037
|
125258
|
125259
|
125260