Attachment 125059 Details for Bug 17600 – Bug 17600: Remove wrong C4::Context imports

[patch] Bug 17600: Remove wrong C4::Context imports

Bug-17600-Remove-wrong-C4Context-imports.patch (text/plain), 2.52 KB, created by Jonathan Druart on 2021-09-20 12:45:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-09-20 12:45:21 UTC

Size: 2.52 KB

patch

obsolete

>From e2a7acce633b5d75ffc1f06ae96a4d30608ac77e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 20 Sep 2021 14:25:48 +0200
>Subject: [PATCH] Bug 17600: Remove wrong C4::Context imports
>
>---
> Koha/Hold.pm                           | 2 +-
> Koha/Template/Plugin/TablesSettings.pm | 2 +-
> misc/translator/LangInstaller.pm       | 2 +-
> t/lib/Mocks.pm                         | 2 +-
> t/lib/Selenium.pm                      | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index 0aa9eab133c..26c41d7924d 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -23,7 +23,7 @@ use Modern::Perl;
> use Data::Dumper qw( Dumper );
> use List::MoreUtils qw( any );
> 
>-use C4::Context qw(preference);
>+use C4::Context;
> use C4::Letters qw( GetPreparedLetter EnqueueLetter );
> use C4::Log qw( logaction );
> 
>diff --git a/Koha/Template/Plugin/TablesSettings.pm b/Koha/Template/Plugin/TablesSettings.pm
>index 4e61e8814fd..25df84e0ae1 100644
>--- a/Koha/Template/Plugin/TablesSettings.pm
>+++ b/Koha/Template/Plugin/TablesSettings.pm
>@@ -56,7 +56,7 @@ use base qw( Template::Plugin );
> 
> use JSON qw( to_json );
> 
>-use C4::Context qw( config );
>+use C4::Context;
> use C4::Utils::DataTables::TablesSettings;
> 
> =head1 FUNCTIONS
>diff --git a/misc/translator/LangInstaller.pm b/misc/translator/LangInstaller.pm
>index 772c876fb32..df4d293a56b 100644
>--- a/misc/translator/LangInstaller.pm
>+++ b/misc/translator/LangInstaller.pm
>@@ -19,7 +19,7 @@ package LangInstaller;
> 
> use Modern::Perl;
> 
>-use C4::Context qw( config preference new interface );
>+use C4::Context;
> # WARNING: Any other tested YAML library fails to work properly in this
> # script content
> # FIXME Really?
>diff --git a/t/lib/Mocks.pm b/t/lib/Mocks.pm
>index 97eb545ebd0..0eaf2106bc7 100644
>--- a/t/lib/Mocks.pm
>+++ b/t/lib/Mocks.pm
>@@ -16,7 +16,7 @@ package t::lib::Mocks;
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use C4::Context qw( config new preference userenv _new_userenv set_userenv );
>+use C4::Context;
> 
> use Test::MockModule;
> use Test::MockObject;
>diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm
>index 8e235e94a7f..3833deab4ee 100644
>--- a/t/lib/Selenium.pm
>+++ b/t/lib/Selenium.pm
>@@ -19,7 +19,7 @@ package t::lib::Selenium;
> use Modern::Perl;
> use Carp qw( croak );
> 
>-use C4::Context qw( new config preference interface );
>+use C4::Context;
> 
> use base qw(Class::Accessor);
> __PACKAGE__->mk_accessors(qw(login password base_url opac_base_url selenium_addr selenium_port driver));
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 17600: 57394 | 57950 | 57951 | 57952 | 57953 | 57954 | 61994 | 61995 | 61996 | 61997 | 61998 | 62209 | 62210 | 62211 | 62212 | 62213 | 62940 | 62941 | 62942 | 62943 | 62958 | 62959 | 64387 | 64388 | 64389 | 64390 | 64391 | 64392 | 64466 | 64467 | 64468 | 64469 | 64470 | 64471 | 64472 | 64473 | 64474 | 64475 | 64476 | 121309 | 121310 | 121311 | 121312 | 121313 | 121314 | 122360 | 122361 | 122362 | 122363 | 122364 | 122365 | 122869 | 122884 | 122945 | 123194 | 123195 | 123196 | 123200 | 123210 | 123281 | 123283 | 123284 | 123325 | 123417 | 123418 | 123419 | 123420 | 123565 | 124866 | 125059 | 125063 | 125064 | 125066 | 126640 | 127056 | 127918