Bugzilla – Attachment 125083 Details for
Bug 29067
Remove duplicate conditional statement from OPAC messaging settings title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title
Bug-29067-Remove-duplicate-conditional-statement-f.patch (text/plain), 1.71 KB, created by
Lari Taskula
on 2021-09-20 22:42:20 UTC
(
hide
)
Description:
Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2021-09-20 22:42:20 UTC
Size:
1.71 KB
patch
obsolete
>From 6ea7dae9ae2107a05e8f02e6fe89188ec8724a60 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Mon, 20 Sep 2021 22:33:42 +0000 >Subject: [PATCH] Bug 29067: Remove duplicate conditional statement from OPAC > messaging settings title > >We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC >messaging preferences title, so it's dead code. > >This patch removes the useless duplicate if-statement. > >To test: >1. Enable EnhancedMessagingPreferencesOPAC system preference >2. Go to /cgi-bin/koha/opac-messaging.pl >3. Observe title Your messaging settings > Koha online catalog >4. Apply patch >5. Refresh page /cgi-bin/koha/opac-messaging.pl >6. Observe same title Your messaging settings > Koha online catalog >7. See patch content >8. Confirm there are no functional changes in the new logic >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >index a1406a1af4..6f4e35d8b2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >@@ -1,6 +1,6 @@ > [% USE Koha %] > [% INCLUDE 'doc-head-open.inc' %] >-<title>Your messaging settings › [% IF ( LibraryNameTitle ) %][% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %][% ELSE %]Koha online[% END %] catalog</title> >+<title>Your messaging settings › [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog</title> > [% INCLUDE 'doc-head-close.inc' %] > [% BLOCK cssinclude %][% END %] > </head> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29067
:
125083
|
125139
|
125315