Bugzilla – Attachment 125117 Details for
Bug 28934
OPAC registration form design is not consistent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28934: Make the OPAC registration form design consistent
Bug-28934-Make-the-OPAC-registration-form-design-c.patch (text/plain), 6.13 KB, created by
Joonas Kylmälä
on 2021-09-21 16:32:49 UTC
(
hide
)
Description:
Bug 28934: Make the OPAC registration form design consistent
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-09-21 16:32:49 UTC
Size:
6.13 KB
patch
obsolete
>From 42dd8d56f8d83a6f0dcc95227e3fd4c30c42d5b4 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi> >Date: Tue, 21 Sep 2021 16:32:00 +0000 >Subject: [PATCH] Bug 28934: Make the OPAC registration form design consistent > >The gender/sex and GDPR inputs were slightly misaligned (by >1.5em). Now they are aligned with the other inputs which have a width >of 10em (9em width + margin 1em). The label assignments and required >attributes for input elements are made also consistent. > >To test: > 1) Enable GDPR_Policy syspref > 2) Apply patch, run "yarn build --view opac", restart plack > 3) Go to /cgi-bin/koha/opac-memberentry.pl > 4) Check that the GDPR input box shows the required text now in red > color > 5) Check that the alignment of sex/gender and GDPR input matches with > the other inputs perfectly. >--- > .../opac-tmpl/bootstrap/css/src/opac.scss | 23 +++++++++++++++++-- > .../bootstrap/en/modules/opac-memberentry.tt | 13 ++++++++--- > 2 files changed, 31 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index c665cfea5d..29f2323dd7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -716,6 +716,13 @@ fieldset { > font-weight: bold; > } > >+ div.label { >+ display: inline-block; >+ width: 9rem; >+ margin-right: 1rem; >+ float: none; >+ } >+ > label, > .label { > float: left; >@@ -725,10 +732,19 @@ fieldset { > width: 9rem; > } > >+ label.checkbox-label { >+ float: none; >+ margin-right: 0; >+ font-weight: normal; >+ text-align: left; >+ width: auto; >+ } >+ > label { > &.error { > color: #C00; > float: none; >+ display: inline; > font-style: italic; > font-weight: normal; > margin-left: 1rem; >@@ -766,6 +782,7 @@ fieldset { > } > } > >+ > li { > clear: left; > float: left; >@@ -774,14 +791,16 @@ fieldset { > width: 100%; > > &.lradio { >- padding-left: 8.5em; > width: auto; > > label { > float: none; >- margin: 0 0 0 1em; >+ margin: 0; > width: auto; > } >+ input { >+ margin-right: 1rem; >+ } > } > } > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index 7f1ad4a58a..790f1e5044 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -373,6 +373,7 @@ > > [% UNLESS hidden.defined('sex') %] > <li class="lradio"> >+ <div class="label"></div> > <label for="sex-female" class="radio inline"><span class="patronsex-female">Female:</span></label> > [% IF borrower.sex == 'F' %] > <input type="radio" name="borrower_sex" id="sex-female" value="F" checked="checked" /> >@@ -871,11 +872,11 @@ > </div> > > <ol> >- <li><label for="borrower_password" class="[% required.password | html %]">Password</label> >+ <li><label for="password" class="[% required.password | html %]">Password:</label> > <input type="password" name="borrower_password" id="password" class="[% required.password | html %]" /> > <div class="required_label [% required.password | html %]">Required</div> > </li> >- <li><label for="borrower_password2" class="[% required.password | html %]">Confirm password</label> >+ <li><label for="password2" class="[% required.password | html %]">Confirm password:</label> > <input type="password" name="borrower_password2" id="password2" /> > <div class="required_label [% required.password | html %]">Required</div> > </li> >@@ -958,7 +959,13 @@ > <legend>GDPR consent</legend> > <ol> > <li> >- <label></label><span><input type="checkbox" name="borrower_gdpr_proc_consent" value="agreed"> I agree with your processing of my personal data as outlined in the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a>. <div class="required">Required</div></span> >+ <div class="label"></div> >+ <label class="checkbox-label" for="borrower_gdpr_proc_consent"> >+ <input type="checkbox" name="borrower_gdpr_proc_consent" id="borrower_gdpr_proc_consent" class="required" value="agreed"> >+ I agree with your processing of my personal data as outlined in the <a target="_blank" href="[% Koha.Preference('PrivacyPolicyURL') | url %]">privacy policy</a>. >+ </label> >+ <label class="error" for="borrower_gdpr_proc_consent" style="display: none;"></label> >+ <div class="required_label required">Required</div> > </li> > </ol> > </fieldset> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28934
:
124322
|
124441
|
124830
|
124852
|
125032
|
125117
|
125123
|
125334