Attachment 125122 Details for Bug 29004 – Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

[patch] Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

Bug-29004-Update-GoogleOpenIDConnect-preference-to.patch (text/plain), 4.45 KB, created by David Nind on 2021-09-21 19:42:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-09-21 19:42:33 UTC

Size: 4.45 KB

patch

obsolete

>From d0a92f894269e4f01b390a64dbfc8b2329fa3375 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 13 Sep 2021 13:37:55 +0000
>Subject: [PATCH] Bug 29004: Update GoogleOpenIDConnect preference to make it
> clear that it is OPAC-only
>
>This patch modifies the description of the GoogleOpenIDConnect and
>related preferences to make it clear that GoogleOpenIDConnect affects
>OPAC logins and that the preferences are related.
>
>To test, apply the patch and go to Administration -> System preferences.
>
>Search for "google," and confirm that the descriptions of
>GoogleOpenIDConnect and related preferences look clear and correct.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../prog/en/modules/admin/preferences/admin.pref   | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>index a858b1d0da..3263d6d031 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>@@ -165,37 +165,39 @@ Administration:
>                   emailAddress: emailAddress
>     Google OpenID Connect:
>         -
>-            - "Use Google OpenID Connect login: "
>+            - "Use Google OpenID Connect login in the OPAC: "
>             - pref: GoogleOpenIDConnect
>               choices:
>                 1: "Yes"
>                 0: "No"
>-            - You will need to select OAuth2 when creating an app in the Google cloud console, and set the web origin to your_opac_url and the redirect url to your_opac_url/cgi-bin/koha/svc/auth/googleopenidconnect .
>+            - You will need to select OAuth2 when creating an app in the Google cloud console, and set the web origin to your_opac_url and the redirect url to your_opac_url/cgi-bin/koha/svc/auth/googleopenidconnect. Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOAuth2ClientID">GoogleOAuth2ClientID</a> and <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOAuth2ClientSecret">GoogleOAuth2ClientSecret</a> to be set.
>         -
>             - "Google OAuth2 Client ID: "
>             - pref: GoogleOAuth2ClientID
>+            -  Along with <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOAuth2ClientSecret">GoogleOAuth2ClientSecret</a>, enables <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOpenIDConnect">GoogleOpenIDConnect.</a>
>         -
>             - "Google OAuth2 Client Secret: "
>             - pref: GoogleOAuth2ClientSecret
>+            -  Along with <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOAuth2ClientID">GoogleOAuth2ClientID</a>, enables <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOpenIDConnect">GoogleOpenIDConnect.</a>
>         -
>             - "Restrict Google OpenID Connect to this domain (or subdomain of this domain): "
>             - pref: GoogleOpenIDConnectDomain
>-            - . Leave blank for all Google domains.
>+            - Leave blank for all Google domains. Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOpenIDConnect">GoogleOpenIDConnect</a>.
>         -
>             - pref: GoogleOpenIDConnectAutoRegister
>               choices:
>                 1: Allow
>                 0: "Don't allow"
>-            - patrons logging in with Google Open ID to automatically register.
>+            - patrons logging in with Google Open ID to automatically register. Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOpenIDConnect">GoogleOpenIDConnect</a>.
>         -
>             - "Use this category code when automatically registering a Google Open ID patron: "
>             - pref: GoogleOpenIDConnectDefaultCategory
>               choices: patron-categories
>-            - "."
>+            - Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOpenIDConnect">GoogleOpenIDConnect</a>.
>         -
>             - "Use this branch code when automatically registering a Google Open ID patron: "
>             - pref: GoogleOpenIDConnectDefaultBranch
>-            - "."
>+            - Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=GoogleOpenIDConnect">GoogleOpenIDConnect</a>.
>     Share anonymous usage statistics:
>         -
>             - "Share anonymous Koha usage data with the Koha community: "
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29004: 124841 | 125122 | 125329