Attachment 125134 Details for Bug 29076 – Bug 29076: Fetch the zebraqueue entries when not confirm

[patch] Bug 29076: Fetch the zebraqueue entries when not confirm

Bug-29076-Fetch-the-zebraqueue-entries-when-not-co.patch (text/plain), 1.44 KB, created by Marcel de Rooy on 2021-09-22 14:46:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-09-22 14:46:13 UTC

Size: 1.44 KB

patch

obsolete

>From ac4b4365534cf3e735da7edecbf946d1632ee148 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 22 Sep 2021 12:02:43 +0000
>Subject: [PATCH] Bug 29076: Fetch the zebraqueue entries when not confirm
>Content-Type: text/plain; charset=utf-8
>
>This patch remove a check for confirm when fetching the entries
>for possible deletion from the zebraqueue
>
>Without this we die when we try to access the entries for counting
>
>To test:
>1 - perl  misc/cronjobs/cleanup_database.pl --sessions --zebraqueue 10 --list-invites --z3950 --logs 180 --mail 375 -v
>2 - Dies
>3 - Apply patch
>4 - Repeat 1
>5 - Success!
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> misc/cronjobs/cleanup_database.pl | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl
>index 94a6301620..17b57d79fc 100755
>--- a/misc/cronjobs/cleanup_database.pl
>+++ b/misc/cronjobs/cleanup_database.pl
>@@ -283,9 +283,7 @@ if ($zebraqueue_days) {
>             WHERE done=1 AND time < date_sub(curdate(), INTERVAL ? DAY)
>         }
>     );
>-    if ( $confirm ) {
>-        $sth->execute($zebraqueue_days) or die $dbh->errstr;
>-    }
>+    $sth->execute($zebraqueue_days) or die $dbh->errstr;
>     $sth2 = $dbh->prepare(q{ DELETE FROM zebraqueue WHERE id=? });
>     while ( my $record = $sth->fetchrow_hashref ) {
>         if ( $confirm ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29076: 125130 | 125131 | 125134