Bugzilla – Attachment 125137 Details for
Bug 28927
Id opacmainuserblock used twice in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28927: Fix id opacmainuserblock used twice in OPAC
Bug-28927-Fix-id-opacmainuserblock-used-twice-in-O.patch (text/plain), 2.58 KB, created by
Owen Leonard
on 2021-09-22 14:56:48 UTC
(
hide
)
Description:
Bug 28927: Fix id opacmainuserblock used twice in OPAC
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-09-22 14:56:48 UTC
Size:
2.58 KB
patch
obsolete
>From 184d84ae5b9fbf559e2a961b3cca1698d35cb6ae Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 30 Aug 2021 20:59:27 -1000 >Subject: [PATCH] Bug 28927: Fix id opacmainuserblock used twice in OPAC > >Since preference OpacMainUserBlock is now an HTML customization, >there is actually an HTML tags with id="opacmainuserblock" and one with id="OpacMainUserBlock". >Same for OPACNavRight in opac-registration-confirmation.tt > >This patch removed id from page to keep the one comming from HTML customization include. > >Test plan : >1) Create an HTML customization for OpacMainUserBlock with some text >2) Go to OPAC main page >3) Check HTML code of the page >4) Check you see id="OpacMainUserBlock" once and not id="opacmainuserblock" >5) Same for id="opacnavright" in opac-registration-confirmation.tt > >https://bugs.koha-community.org/show_bug.cgi?id=28927 > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 4 +--- > .../bootstrap/en/modules/opac-registration-confirmation.tt | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >index d46100fcbe..5e0c99f229 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >@@ -167,9 +167,7 @@ > [% END %] > > [% IF ( OpacMainUserBlock ) %] >- <div id="opacmainuserblock"> >- [% PROCESS koha_news_block news => OpacMainUserBlock %] >- </div> >+ [% PROCESS koha_news_block news => OpacMainUserBlock %] > [% END %] > [% END %] > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >index b688de43d1..d2ab28b68f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >@@ -106,9 +106,7 @@ > [% END # /casAuthentication %] > [% END # / loggedinusername %] > [% IF ( OpacNavRight ) %] >- <div id="opacnavright"> >- [% PROCESS koha_news_block news => OpacNavRight %] >- </div> >+ [% PROCESS koha_news_block news => OpacNavRight %] > [% END # /OpacNavRight %] > </div> <!-- / .col-lg-3 --> > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28927
:
124267
|
124318
|
124637
|
124638
|
124793
|
124794
|
125125
|
125126
|
125137
|
125138
|
125332
|
125333