Bugzilla – Attachment 125176 Details for
Bug 29086
Reuse article request filtering methods in Biblio template plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses
Bug-29086-follow-up-Remove-unrequired-KohaArticleR.patch (text/plain), 1.29 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-09-22 19:56:00 UTC
(
hide
)
Description:
Bug 29086: (follow-up) Remove unrequired Koha::ArticleRequest::Status uses
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-09-22 19:56:00 UTC
Size:
1.29 KB
patch
obsolete
>From 6fad703cd698b8eb83d2c41422625357995e9d90 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 22 Sep 2021 16:53:50 -0300 >Subject: [PATCH] Bug 29086: (follow-up) Remove unrequired > Koha::ArticleRequest::Status uses > >I noticed a couple places in which this library was included but not >used. > >To test: >1. Apply this patch >2. Run: > $ git grep 'Koha::ArticleRequest::Status' >=> SUCCESS: There aren't any calls to their defined constants in >Biblio.pm or Patrons.pm >3. Sign off :-D >--- > Koha/Biblio.pm | 1 - > Koha/Patrons.pm | 1 - > 2 files changed, 2 deletions(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index 968a370b25..dadb53b322 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -31,7 +31,6 @@ use Koha::DateUtils qw( dt_from_string ); > use base qw(Koha::Object); > > use Koha::Acquisition::Orders; >-use Koha::ArticleRequest::Status; > use Koha::ArticleRequests; > use Koha::Biblio::Metadatas; > use Koha::Biblioitems; >diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm >index 4f2b55956a..8e8bed9a0c 100644 >--- a/Koha/Patrons.pm >+++ b/Koha/Patrons.pm >@@ -25,7 +25,6 @@ use Koha::Database; > use Koha::DateUtils qw( dt_from_string ); > > use Koha::ArticleRequests; >-use Koha::ArticleRequest::Status; > use Koha::Patron; > use Koha::Exceptions::Patron; > use Koha::Patron::Categories; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29086
:
125175
|
125176
|
125246
|
125247
|
125347
|
125348