Bugzilla – Attachment 125253 Details for
Bug 29107
item_type should be item_type_id on item response object
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29107: Rename item_type => item_type_id
Bug-29107-Rename-itemtype--itemtypeid.patch (text/plain), 2.07 KB, created by
Martin Renvoize (ashimema)
on 2021-09-24 14:20:25 UTC
(
hide
)
Description:
Bug 29107: Rename item_type => item_type_id
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-09-24 14:20:25 UTC
Size:
2.07 KB
patch
obsolete
>From d57d759d97850580d6833051d57f9151b100ba07 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 24 Sep 2021 08:28:17 -0300 >Subject: [PATCH] Bug 29107: Rename item_type => item_type_id > >This simple change renames the attribute in the item object API >representation. > >To test: >1. Run: > $ kshell > k$ prove t/db_dependent/api/v1/items.t >=> SUCCESS: Tests pass >2. Run: > $ git grep 'api/v1/items' >=> SUCCESS: The items routes are not (yet) used in Koha >3. Run: > $ cd koha-tmpl > $ git grep --name-only '"embed"' >=> SUCCESS: Only two templates are using embed. >4. Check: > - register.tt uses it to embed the manager, good > - parcel.tt uses it to embed items. Alert. >=> SUCCESS: parcel.tt only uses a count on items. No item_type involved. >5. Sign off > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Item.pm | 2 +- > api/v1/swagger/definitions/item.json | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 60d80a5c3eb..c8f0acdfee6 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -1151,7 +1151,7 @@ sub to_api_mapping { > ccode => 'collection_code', > materials => 'materials_notes', > uri => 'uri', >- itype => 'item_type', >+ itype => 'item_type_id', > more_subfields_xml => 'extended_subfields', > enumchron => 'serial_issue_number', > copynumber => 'copy_number', >diff --git a/api/v1/swagger/definitions/item.json b/api/v1/swagger/definitions/item.json >index 14c110714e3..72e6b082140 100644 >--- a/api/v1/swagger/definitions/item.json >+++ b/api/v1/swagger/definitions/item.json >@@ -153,7 +153,7 @@ > "type": ["string", "null"], > "description": "URL for the item" > }, >- "item_type": { >+ "item_type_id": { > "type": ["string", "null"], > "description": "Itemtype defining the type for this item" > }, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29107
:
125236
| 125253