Bugzilla – Attachment 125336 Details for
Bug 29025
Saved auth login and password are pre-filled in patron creation form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29025: Don't prefill userid and password in user creation form
Bug-29025-Dont-prefill-userid-and-password-in-user.patch (text/plain), 4.24 KB, created by
Katrin Fischer
on 2021-09-26 13:55:28 UTC
(
hide
)
Description:
Bug 29025: Don't prefill userid and password in user creation form
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-09-26 13:55:28 UTC
Size:
4.24 KB
patch
obsolete
>From fd1f0f2c0351de8ced398528c056d9a9a64df7a1 Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Wed, 15 Sep 2021 07:32:34 +0200 >Subject: [PATCH] Bug 29025: Don't prefill userid and password in user creation > form > >Recent Firefox versions try to prefill userid and password with >logged in user credentials. > >To test >1 - Log in staff as user foo password bar >2 - Save user and password in Firefox >3 - Log out >4 - Log in again, log in pop-up must be pre-filled >5 - Open Create a new patron form >6 - At least password field is pre-filled with logged in user's credentials >7 - Apply patch >8 - Redo 4 and 5 >9 - Userid and password fields aren't prefilled > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 49ab35f70f..f303694234 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1184,9 +1184,9 @@ legend:hover { > [% END %] > [% ELSE %] > [% IF ( opduplicate ) %] >- <input type="password" id="password" name="password" size="20" /> >+ <input type="password" id="password" name="password" size="20" autocomplete="new-password" /> > [% ELSE %] >- <input type="password" id="password" name="password" size="20" value="[% password | html %]" /> >+ <input type="password" id="password" name="password" size="20" autocomplete="new-password" value="[% password | html %]" /> > [% END %] > [% END # /IF ( NoUpdateLogin ) %] > [% ELSE # IF ( opadd ) %] >@@ -1196,7 +1196,7 @@ legend:hover { > <input type="password" id="password" name="password" size="20" disabled="disabled" value="****" /> > [% ELSE %] > [% IF ( opduplicate ) %] >- <input type="password" id="password" name="password" size="20" /> >+ <input type="password" id="password" name="password" autocomplete="new-password" size="20" /> > [% ELSE %] > <input type="password" id="password" name="password" size="20" value="****" /> > [% END %] >@@ -1205,7 +1205,7 @@ legend:hover { > [% IF ( NoUpdateLogin ) %] > <input type="password" id="password" name="password" size="20" disabled="disabled" value="" /> > [% ELSE %] >- <input type="password" id="password" name="password" size="20" value="" /> >+ <input type="password" id="password" name="password" size="20" autocomplete="new-password" value="" /> > [% END %] > [% END # /IF ( password ) %] > [% END # /IF ( opadd ) %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29025
:
124873
|
124889
| 125336