Bugzilla – Attachment 12535 Details for
Bug 8820
Don't show orders table if there are no orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8820 - Don't show orders table if there are no orders
SIGNED-OFF-Bug-8820---Dont-show-orders-table-if-th.patch (text/plain), 3.59 KB, created by
Nicole C. Engard
on 2012-09-26 16:49:11 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8820 - Don't show orders table if there are no orders
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2012-09-26 16:49:11 UTC
Size:
3.59 KB
patch
obsolete
>From 0e0fbf8f3c990ead820240ef4aed86d04e19b79e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 25 Sep 2012 14:28:42 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 8820 - Don't show orders table if there are no orders > >This page removes the "basket empty" message in favor of >hiding the orders table altogether when a basket has no >orders. This patch also moves the "Show all details" >checkbox under the "Orders" heading to associate it more >closely with the area it affects. > >Other textual changes: > >- Correcting capitalization according to coding guidelines >- Correcting terminology (basket group instead of basketgroup) >- Replacing the "Order Details" heading with the more > succinct "Orders" > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 16 ++++++---------- > 1 files changed, 6 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index bd9d145..f271823 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -251,8 +251,8 @@ > <input type="submit" value="Change basket group" /></p> > > </form> >- [% IF ( basketgroupdeliveryplace ) %]<p>Basketgroup Delivery place: [% basketgroupdeliveryplace %]</p>[% END %] >- [% IF ( basketgroupbillingplace ) %]<p>Basketgroup Billing place: [% basketgroupbillingplace %]</p>[% END %] >+ [% IF ( basketgroupdeliveryplace ) %]<p>Basket group delivery place: [% basketgroupdeliveryplace %]</p>[% END %] >+ [% IF ( basketgroupbillingplace ) %]<p>Basket group billing place: [% basketgroupbillingplace %]</p>[% END %] > </div> > [% END %] > </div> >@@ -261,12 +261,12 @@ > > [% UNLESS ( delete_confirm ) %] > <div id="acqui_basket_content" class="yui-g"> >+ [% IF ( books_loop ) %] >+ <h2>Orders</h2> > <label for="show_all_details"> > <input type="checkbox" style="vertical-align: middle;" id="show_all_details" /> > Show all details > </label> >- <h2>Order Details</h2> >- [% IF ( books_loop ) %] > <table id="orders"> > <thead> > <tr> >@@ -394,10 +394,6 @@ > [% END %] > </tbody> > </table> >- [% ELSE %] >- <table> >- <tr><td>Basket empty</td></tr> >- </table> > [% END %] > [% IF ( listincgst ) %]<small class="highlight">** Vendor's listings already include tax.</small> > [% END %] >@@ -478,8 +474,8 @@ > <input type="hidden" name="booksellerid" value="[% booksellerid %]" /> > <input type="hidden" name="confirm" value="1" /> > <input type="hidden" name="basketgroupname" value="[% basketgroupname %]" /> >- <input type="submit" class="approve" value="Yes, Close (Y)" accesskey="y" /> >- <input type="submit" class="deny" value="No, Don't Close (N)" accesskey="n" onclick="javascript:window.location='/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno %]';return false;" /> >+ <input type="submit" class="approve" value="Yes, close (Y)" accesskey="y" /> >+ <input type="submit" class="deny" value="No, don't close (N)" accesskey="n" onclick="javascript:window.location='/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno %]';return false;" /> > </form> > </div> > [% END %] >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8820
:
12505
|
12535
|
13611
|
13805
|
13814