Attachment 125447 Details for Bug 26351 – Bug 26351: Revert improper change to unit test, fix number of tests

[patch] Bug 26351: Revert improper change to unit test, fix number of tests

Bug-26351-Revert-improper-change-to-unit-test-fix-.patch (text/plain), 1.20 KB, created by Kyle M Hall (khall) on 2021-09-29 11:00:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-09-29 11:00:12 UTC

Size: 1.20 KB

patch

obsolete

>From 813640b9ebc19830ada11e23cec88622f4b2dfb8 Mon Sep 17 00:00:00 2001
>From: Kyle Hall <kyle@bywatersolutions.com>
>Date: Wed, 29 Sep 2021 06:59:46 -0400
>Subject: [PATCH] Bug 26351: Revert improper change to unit test, fix number of
> tests
>
>---
> t/db_dependent/Koha/Plugins/Plugins.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Plugins/Plugins.t b/t/db_dependent/Koha/Plugins/Plugins.t
>index f093a0a8e87..b21ca96cd9e 100755
>--- a/t/db_dependent/Koha/Plugins/Plugins.t
>+++ b/t/db_dependent/Koha/Plugins/Plugins.t
>@@ -25,7 +25,7 @@ use File::Temp qw( tempdir tempfile );
> use FindBin qw($Bin);
> use Module::Load::Conditional qw(can_load);
> use Test::MockModule;
>-use Test::More tests => 55;
>+use Test::More tests => 57;
> 
> use C4::Context;
> use Koha::Database;
>@@ -126,7 +126,7 @@ subtest 'GetPlugins() tests' => sub {
> 
>     @plugins = $plugins->GetPlugins({ metadata => { my_example_tag  => 'find_me' }, all => 1 });
>     @names = map { $_->get_metadata()->{'name'} } @plugins;
>-    is( scalar @names, 4, "Only four plugins found via a metadata tag" );
>+    is( scalar @names, 2, "Only two plugins found via a metadata tag" );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26351: 109532 | 109548 | 109671 | 110844 | 110846 | 111575 | 111577 | 111578 | 111579 | 111862 | 111863 | 111894 | 111916 | 111917 | 111918 | 111919 | 111920 | 111921 | 111922 | 113571 | 113572 | 113573 | 113574 | 113575 | 113576 | 113577 | 113578 | 115172 | 115173 | 115174 | 115175 | 115176 | 115177 | 115178 | 115179 | 115180 | 118649 | 118650 | 118651 | 118652 | 118653 | 118654 | 118655 | 118656 | 118657 | 118658 | 118681 | 118682 | 118683 | 118684 | 118685 | 118686 | 118687 | 118688 | 118689 | 118690 | 122433 | 122434 | 122435 | 122436 | 122437 | 122438 | 122439 | 122440 | 122441 | 122442 | 124258 | 124259 | 124260 | 124261 | 124262 | 124263 | 124264 | 124265 | 124266 | 124313 | 125447 | 125763 | 125764 | 125765