Attachment 125488 Details for Bug 29058 – Bug 29058: (follow-up) Add hold count and don't display show options if no holds

[patch] Bug 29058: (follow-up) Add hold count and don't display show options if no holds

Bug-29058-follow-up-Add-hold-count-and-dont-displa.patch (text/plain), 2.56 KB, created by Nick Clemens (kidclamp) on 2021-09-30 11:05:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-09-30 11:05:59 UTC

Size: 2.56 KB

patch

obsolete

>From d2e86d4518eab5b3c2f8811c3ca5f0119f42fb04 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 21 Sep 2021 10:44:48 +0000
>Subject: [PATCH] Bug 29058: (follow-up) Add hold count and don't display show
> options if no holds
>
>---
> .../prog/en/modules/reserve/request.tt        | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index cd13ceb3a7..27d824d4d8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -3,6 +3,7 @@
> [% USE Asset %]
> [% USE JSON.Escape %]
> [% USE Koha %]
>+[% USE Biblio %]
> [% USE KohaDates %]
> [% USE Branches %]
> [% USE Categories %]
>@@ -879,14 +880,16 @@
>             [% END %]
> 
>             [% UNLESS ( patron ) %]
>-
>-                        <label for ="always_show_holds">Always show holds</label>
>-                        [% IF always_show_holds == 'DONT' %]
>-                            <input type="checkbox" name="always_show_holds" id="always_show_holds" value="DO">
>-                            <a class="btn btn-default" value="Show holds" id="show_holds_now" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber %]&show_holds_now=1">Show holds</a>
>-                        [% ELSE %]
>-                            <input type="checkbox" name="always_show_holds" value="DO" id="always_show_holds" checked="checked">
>-                        [% END %]
>+                [% SET hold_count = Biblio.HoldsCount( biblio.biblionumber ) | html %]
>+                [% IF hold_count %]
>+                    <label for ="always_show_holds">Always show holds</label>
>+                    [% IF always_show_holds == 'DONT' %]
>+                        <input type="checkbox" name="always_show_holds" id="always_show_holds" value="DO">
>+                        <a class="btn btn-default" value="Show holds" id="show_holds_now" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber %]&show_holds_now=1">Show holds ([% hold_count %])</a>
>+                    [% ELSE %]
>+                        <input type="checkbox" name="always_show_holds" value="DO" id="always_show_holds" checked="checked">
>+                    [% END %]
>+                [% END %]
>                 [% IF ( reserveloop ) %]
>                     <form id="existing_holds" name="T[% time | html %]" action="modrequest.pl" method="post" style="display:block">
>                         [% IF ( multi_hold ) %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29058: 125054 | 125062 | 125091 | 125487 | 125488 | 126995 | 129924 | 129925 | 129930 | 129931 | 129932 | 129933