Attachment 125593 Details for Bug 29139 – Bug 29139: Fix incorrect relation call

[patch] Bug 29139: Fix incorrect relation call

Bug-29139-Fix-incorrect-relation-call.patch (text/plain), 1.19 KB, created by Martin Renvoize (ashimema) on 2021-10-01 09:16:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-10-01 09:16:57 UTC

Size: 1.19 KB

patch

obsolete

>From edacf9abf866f5a9b90eaa05ddf356d4e2deff8c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 30 Sep 2021 09:14:15 +0100
>Subject: [PATCH] Bug 29139: Fix incorrect relation call
>
>The bug here was worse than originally thought. We were calling the
>wrong relation too.. we should probably add some exceptions to catch
>this, it confuses me every single time!
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Account.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Account.pm b/Koha/Account.pm
>index 47961df279..45f0fa6f64 100644
>--- a/Koha/Account.pm
>+++ b/Koha/Account.pm
>@@ -110,7 +110,7 @@ sub pay {
>     }
> 
>     my $patron = Koha::Patrons->find( $self->{patron_id} );
>-    my @account_offsets = $payment->debit_offsets->as_list;
>+    my @account_offsets = $payment->credit_offsets->as_list;
>     if ( C4::Context->preference('UseEmailReceipts') ) {
>         if (
>             my $letter = C4::Letters::GetPreparedLetter(
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29139: 125463 | 125464 | 125474 | 125475 | 125476 | 125504 | 125505 | 125506 | 125507 | 125508 | 125509 | 125510 | 125511 | 125512 | 125513 | 125592 | 125593 | 125594 | 125595 | 125596 | 125844 | 125845 | 125846 | 125847 | 125848