Attachment 125618 Details for Bug 27526 – Bug 27526: Fix cn_source display

[patch] Bug 27526: Fix cn_source display

Bug-27526-Fix-cnsource-display.patch (text/plain), 1.42 KB, created by Tomás Cohen Arazi (tcohen) on 2021-10-01 11:34:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-10-01 11:34:02 UTC

Size: 1.42 KB

patch

obsolete

>From 0edd2052aad3fe8315e6daea5cc5cb39d0cc187b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 23 Jul 2021 15:16:32 +0200
>Subject: [PATCH] Bug 27526: Fix cn_source display
>
>For an unknown reason C4::Biblio::GetAuthorisedValueDesc (that we are
>calling from Koha::Item->columns_to_str) does not deal with class
>sources.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/Biblio.pm | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index cf79d1e4b3..d2df1b5111 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -91,7 +91,7 @@ use Module::Load::Conditional qw( can_load );
> use C4::Koha;
> use C4::Log qw( logaction );    # logaction
> use C4::Budgets;
>-use C4::ClassSource qw( GetClassSort );
>+use C4::ClassSource qw( GetClassSort GetClassSource );
> use C4::Charset qw(
>     nsb_clean
>     SetMarcUnicodeFlag
>@@ -1426,6 +1426,11 @@ sub GetAuthorisedValueDesc {
>             return $itemtype ? $itemtype->translated_description : q||;
>         }
> 
>+        if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "cn_source" ) {
>+            my $source = GetClassSource($value);
>+            return $source ? $source->{description} : q||;
>+        }
>+
>         #---- "true" authorized value
>         $category = $tagslib->{$tag}->{$subfield}->{'authorised_value'};
>     }
>-- 
>2.32.0

Actions: View | Diff | Splinter Review

Attachments on bug 27526: 115679 | 115680 | 116006 | 117806 | 117807 | 117808 | 121589 | 121590 | 121591 | 122288 | 122318 | 122655 | 122656 | 122657 | 122658 | 122676 | 122677 | 122681 | 122682 | 122694 | 122695 | 122696 | 122946 | 122947 | 122948 | 122949 | 122950 | 122951 | 122952 | 122953 | 122954 | 122957 | 122958 | 122959 | 122974 | 123006 | 123007 | 123110 | 123329 | 123372 | 123415 | 123757 | 123758 | 123759 | 123760 | 123761 | 123762 | 123763 | 123764 | 123765 | 123766 | 123767 | 123768 | 123769 | 123770 | 123771 | 123772 | 125069 | 125605 | 125606 | 125607 | 125608 | 125609 | 125610 | 125611 | 125612 | 125613 | 125614 | 125615 | 125616 | 125617 | 125618 | 125619 | 125620 | 125818 | 125839 | 125863 | 126034 | 126051 | 126143 | 126144 | 126393 | 127025 | 127032