Attachment 125654 Details for Bug 29111 – Bug 29111: Remove unused function from cataloguing/additem.pl

[patch] Bug 29111: Remove unused function from cataloguing/additem.pl

Bug-29111-Remove-unused-function-from-cataloguinga.patch (text/plain), 1.37 KB, created by Katrin Fischer on 2021-10-02 20:16:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-10-02 20:16:32 UTC

Size: 1.37 KB

patch

obsolete

>From 1c9426a9598a2d398853a582a3848fcaada97186 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Sun, 26 Sep 2021 08:14:19 +0000
>Subject: [PATCH] Bug 29111: Remove unused function from cataloguing/additem.pl
>
>To test:
> 1) Open cataloguing/additem.pl and search for any usages of
> find_value, you should find 0 usages.
>
>Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> cataloguing/additem.pl | 16 ----------------
> 1 file changed, 16 deletions(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index 17814f2a60..120e4c0b23 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -58,22 +58,6 @@ use MIME::Base64 qw( decode_base64url encode_base64url );
> 
> our $dbh = C4::Context->dbh;
> 
>-sub find_value {
>-    my ($tagfield,$insubfield,$record) = @_;
>-    my $result;
>-    my $indicator;
>-    foreach my $field ($record->field($tagfield)) {
>-        my @subfields = $field->subfields();
>-        foreach my $subfield (@subfields) {
>-            if (@$subfield[0] eq $insubfield) {
>-                $result .= @$subfield[1];
>-                $indicator = $field->indicator(1).$field->indicator(2);
>-            }
>-        }
>-    }
>-    return($indicator,$result);
>-}
>-
> sub get_item_from_barcode {
>     my ($barcode)=@_;
>     my $dbh=C4::Context->dbh;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 29111: 125311 | 125312 | 125313 | 125601 | 125602 | 125603 | 125652 | 125653 | 125654 | 125996 | 125997