Attachment 125665 Details for Bug 28930 – Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration.

[patch] Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration.

Bug-28930-Keep-cardnumber-be-editable-after-server.patch (text/plain), 2.32 KB, created by Joonas Kylmälä on 2021-10-03 09:48:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-10-03 09:48:01 UTC

Size: 2.32 KB

patch

obsolete

>From 33b5981f0c981808fe4e3a8341c26bfe78fe5c12 Mon Sep 17 00:00:00 2001
>From: Andreas Jonsson <andreas.jonsson@kreablo.se>
>Date: Tue, 31 Aug 2021 12:50:03 +0000
>Subject: [PATCH] Bug 28930: Keep cardnumber be editable after server side form
> validation fails during self registration.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>
>- Enable the system preference PatronSelfRegistration
>- Make sure  PatronSelfRegistrationBorrowerUnwantedField does not
>  contain cardnumber.
>- Set the system preference  GDPR_Policy to "Enforce".
>- In the OPAC click "Log in to your account" and "Register here".
>- Fill out the form with valid data, but make sure you leave the
>  checkbox under "GDPR consent" unchecked.
>- Submit the form
>- You will get back the form with the error message "You have not filled
>  out all required fields. Please fill in all missing fields and
>  resubmit."
>- Without patch: cardnumber is not editable, and there is no input
>  element for borrower_cardnumber (so the cardnumber will be lost when
>  resubmitting the form)
>- With patch: cardnumber is editable.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index 790f1e5044..c7f7c9c503 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -209,7 +209,7 @@
> 
>                                                 <label for="borrower_cardnumber" class="[% required.cardnumber | html %]">Library card number:</label>
> 
>-                                                [% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) %]
>+                                                [% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) && action == 'edit' %]
>                                                     [% borrower.cardnumber | html %]
>                                                 [% ELSE %]
>                                                     [% IF minlength_cardnumber == maxlength_cardnumber %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28930: 124278 | 124320 | 125665