Attachment 125729 Details for Bug 3142 – Bug 3142: Add itype

[patch] Bug 3142: Add itype

Bug-3142-Add-itype.patch (text/plain), 1.40 KB, created by Martin Renvoize (ashimema) on 2021-10-05 11:31:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-10-05 11:31:48 UTC

Size: 1.40 KB

patch

obsolete

>From abfc9a8571d201650dcbce73c747c850202e6f92 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 22 Jun 2021 15:43:10 +0200
>Subject: [PATCH] Bug 3142: Add itype
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Items.pm | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/Koha/Items.pm b/Koha/Items.pm
>index 0ec3133d8a..3f27ecbd4b 100644
>--- a/Koha/Items.pm
>+++ b/Koha/Items.pm
>@@ -23,6 +23,7 @@ use Modern::Perl;
> use Koha::Database;
> 
> use Koha::Item;
>+use Koha::CirculationRules;
> 
> use base qw(Koha::Objects);
> 
>@@ -49,6 +50,15 @@ Return the items of the set that are holdable
> sub filter_by_for_hold {
>     my ($self) = @_;
> 
>+    my @hold_not_allowed_itypes = Koha::CirculationRules->search(
>+        {
>+            rule_name    => 'holdallowed',
>+            branchcode   => undef,
>+            categorycode => undef,
>+            rule_value   => 'not_allowed',
>+        }
>+    )->get_column('itemtype');
>+
>     return $self->search(
>         {
>             itemlost   => 0,
>@@ -56,6 +66,7 @@ sub filter_by_for_hold {
>             notforloan => { '<=' => 0 }
>             ,    # items with negative or zero notforloan value are holdable
>             ( C4::Context->preference('AllowHoldsOnDamagedItems') ? ( damaged => 0 ) : () ),
>+            itype        => { -not_in => \@hold_not_allowed_itypes },
>         }
>     );
> }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 3142: 122284 | 122285 | 122286 | 122287 | 122314 | 122315 | 122316 | 122317 | 125727 | 125728 | 125729 | 125730 | 125732 | 125733 | 125734 | 125942 | 125943 | 125944 | 125945 | 125946 | 125947 | 125948 | 125949 | 125950 | 125951 | 125956 | 125967 | 125968 | 125969 | 125970 | 125971 | 125972 | 125973 | 125974 | 125975 | 125976 | 125977