Bugzilla – Attachment 125734 Details for
Bug 3142
Standardize how OPAC and staff determine requestability
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3142: Add note about imprecision of filter_by_for_hold
Bug-3142-Add-note-about-imprecision-of-filterbyfor.patch (text/plain), 813 bytes, created by
Jonathan Druart
on 2021-10-05 12:33:18 UTC
(
hide
)
Description:
Bug 3142: Add note about imprecision of filter_by_for_hold
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-10-05 12:33:18 UTC
Size:
813 bytes
patch
obsolete
>From 9d69b058697422c28edede4e94f2c22f46ef9417 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 5 Oct 2021 14:32:47 +0200 >Subject: [PATCH] Bug 3142: Add note about imprecision of filter_by_for_hold > >--- > Koha/Items.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/Koha/Items.pm b/Koha/Items.pm >index 895123c7beb..ced8653b46e 100644 >--- a/Koha/Items.pm >+++ b/Koha/Items.pm >@@ -43,7 +43,10 @@ Koha::Items - Koha Item object set class > > my $filtered_items = $items->filter_by_for_hold; > >-Return the items of the set that are holdable >+Return the items of the set that are *potentially* holdable >+ >+Caller has the responsability to call C4::Reserves::CanItemBeReserved before >+placing a hold on one of those items. > > =cut > >-- >2.25.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=125734">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3142
:
122284
|
122285
|
122286
|
122287
|
122314
|
122315
|
122316
|
122317
|
125727
|
125728
|
125729
|
125730
|
125732
|
125733
|
125734
|
125942
|
125943
|
125944
|
125945
|
125946
|
125947
|
125948
|
125949
|
125950
|
125951
|
125956
|
125967
|
125968
|
125969
|
125970
|
125971
|
125972
|
125973
|
125974
|
125975
|
125976
|
125977