Attachment 125762 Details for Bug 27944 – Bug 27944: Fix t/db_dependent/AuthorisedValues.t

[patch] Bug 27944: Fix t/db_dependent/AuthorisedValues.t

Bug-27944-Fix-tdbdependentAuthorisedValuest.patch (text/plain), 1.57 KB, created by Jonathan Druart on 2021-10-06 09:43:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-10-06 09:43:58 UTC

Size: 1.57 KB

patch

obsolete

>From 678d205f668e1d2f367cd7546ebe85b0516b61d4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Oct 2021 11:42:48 +0200
>Subject: [PATCH] Bug 27944: Fix t/db_dependent/AuthorisedValues.t
>
> #   Failed test 'The second category should be correct (ordered by category name)'
> #   at t/db_dependent/AuthorisedValues.t line 141.
> #          got: 'AR_CANCELLATION'
> #     expected: 'av_for_testing'
>---
> t/db_dependent/AuthorisedValues.t | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/AuthorisedValues.t b/t/db_dependent/AuthorisedValues.t
>index e16f1faa898..d39d13170c7 100755
>--- a/t/db_dependent/AuthorisedValues.t
>+++ b/t/db_dependent/AuthorisedValues.t
>@@ -1,7 +1,7 @@
> #!/usr/bin/perl
> 
> use Modern::Perl;
>-use Test::More tests => 17;
>+use Test::More tests => 16;
> use Try::Tiny;
> 
> use t::lib::TestBuilder;
>@@ -137,8 +137,11 @@ is( @$limits, 2, 'library_limits functions correctly both as setter and getter'
> 
> my @categories = Koha::AuthorisedValues->new->categories;
> is( @categories, @existing_categories+3, 'There should have 3 categories inserted' );
>-is( $categories[0], $av4->category, 'The first category should be correct (ordered by category name)' );
>-is( $categories[1], $av1->category, 'The second category should be correct (ordered by category name)' );
>+is_deeply(
>+    \@categories,
>+    [ sort { uc $a cmp uc $b } @categories ],
>+    'categories must be ordered by category names'
>+);
> 
> subtest 'search_by_*_field + find_by_koha_field + get_description' => sub {
>     plan tests => 5;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 27944: 119020 | 119021 | 119022 | 120454 | 122673 | 122836 | 122837 | 122838 | 122839 | 122842 | 122843 | 122857 | 122984 | 122985 | 122986 | 122987 | 122988 | 122989 | 122990 | 123710 | 123711 | 123712 | 123943 | 123944 | 123945 | 123946 | 123947 | 123948 | 123949 | 123950 | 123951 | 123952 | 124966 | 124967 | 124968 | 124969 | 124970 | 124971 | 124972 | 124973 | 124974 | 124975 | 124976 | 125158 | 125544 | 125565 | 125567 | 125762 | 125813