Attachment 125766 Details for Bug 29131 – Bug 29131: Row striping breaks color coding on item circulation alerts

[patch] Bug 29131: Row striping breaks color coding on item circulation alerts

Bug-29131-Row-striping-breaks-color-coding-on-item.patch (text/plain), 3.39 KB, created by Nick Clemens (kidclamp) on 2021-10-06 11:01:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-10-06 11:01:30 UTC

Size: 3.39 KB

patch

obsolete

>From 862e7134bcd356c362a3a3f072746863f7821c0a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 5 Oct 2021 12:12:34 +0000
>Subject: [PATCH] Bug 29131: Row striping breaks color coding on item
> circulation alerts
>
>The CSS we use for table row "striping," which uses 'tbody
>tr:nth-child(odd),' is often difficult to work with because it takes a
>lot of increased specificity to override the default. Bootstrap
>compounds this by adding its own similar CSS.
>
>In order to overcome this I've added '!important' to the CSS embedded in
>the item circulation alerts page. I normally would avoid '!important'
>but since this CSS is only relevant to this page I think it's
>appropriate.
>
>This patch also adds [% FILTER collapse %] around the <style> block and
>does some reindenting, so ignore whitespace when using diff to see the
>changes clearly.
>
>To test, apply the patch and go to Administration -> Item circulation
>alerts.
>
>- Check the "Legend" table. The first cells should be distinct colors:
>  red, pink, and green.
>- In the "Checkout" table, table cells should be green by default.
>  Clicking in one of the cells should turn it red with the text
>  "Disabled for all."
>- Use the "Select a library" dropdown to pick a library.
>- Clicking in any green cell should turn the cell pink and add the text
>  "Disabled for XXX" where XXX is the branchcode.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../modules/admin/item_circulation_alerts.tt  | 72 ++++++++++---------
> 1 file changed, 37 insertions(+), 35 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt
>index 9cdef2b019..0ede343b8d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt
>@@ -5,41 +5,43 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Item circulation alerts &rsaquo; Administration &rsaquo; Koha</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-<style>
>-table.grid thead th {
>-  vertical-align: bottom;
>-}
>-
>-table.grid tbody th {
>-  text-align: right;
>-}
>-
>-table.grid tbody td {
>-  font-size: xx-small;
>-}
>-
>-table.grid tbody td.info {
>-  background: #fff;
>-}
>-
>-table.grid.active tbody td {
>-  width: 10%;
>-  cursor: pointer;
>-}
>-
>-table.grid tbody td {
>-  background: #cfc;
>-  color: #111;
>-}
>-
>-table.grid td.disabled {
>-  background: #fcc;
>-}
>-
>-table.grid td.default {
>-  background: #f88;
>-}
>-</style>
>+[% FILTER collapse %]
>+    <style>
>+        table.grid thead th {
>+            vertical-align: bottom;
>+        }
>+
>+        table.grid tbody th {
>+            text-align: right;
>+        }
>+
>+        table.grid tbody td {
>+            font-size: xx-small;
>+        }
>+
>+        table.grid tbody td.info {
>+            background-color: #fff !important;
>+        }
>+
>+        table.grid.active tbody td {
>+            width: 10%;
>+            cursor: pointer;
>+        }
>+
>+        table.grid tbody td {
>+            background-color: #cfc !important;
>+            color: #111;
>+        }
>+
>+        table.grid td.disabled {
>+            background-color: #fcc !important;
>+        }
>+
>+        table.grid td.default {
>+            background-color: #f88 !important;
>+        }
>+    </style>
>+[% END %]
> </head>
> 
> <body id="admin_item_circulation_alerts" class="admin">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29131: 125735 | 125757 | 125766