Attachment 125773 Details for Bug 29093 – Bug 29093: Interface changes

[patch] Bug 29093: Interface changes

Bug-29093-Interface-changes.patch (text/plain), 9.98 KB, created by Marcel de Rooy on 2021-10-06 11:27:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-10-06 11:27:11 UTC

Size: 9.98 KB

patch

obsolete

>From 1fa7370144a0cfe4b80ece7ba2b7d3d2ce2b2894 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 23 Sep 2021 13:23:44 +0000
>Subject: [PATCH] Bug 29093: Interface changes
>Content-Type: text/plain; charset=utf-8
>
>Show the TOC checkbox on OPAC and staff.
>
>Test plan:
>Add new article request on OPAC or staff. Tick checkbox.
>Verify if TOC is Yes on opac-user or staff patron details.
>Check the list view on circ/article-requests.pl.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> circ/request-article.pl | 2 ++
> .../prog/en/includes/patron-article-requests.inc | 5 +++++
> .../intranet-tmpl/prog/en/modules/circ/article-requests.tt | 2 ++
> .../intranet-tmpl/prog/en/modules/circ/request-article.tt | 7 +++++++
> .../opac-tmpl/bootstrap/en/modules/opac-request-article.tt | 5 +++++
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 5 +++++
> opac/opac-request-article.pl | 2 ++
> 7 files changed, 28 insertions(+)
>
>diff --git a/circ/request-article.pl b/circ/request-article.pl
>index 1c92927b82..dbe91dd52f 100755
>--- a/circ/request-article.pl
>+++ b/circ/request-article.pl
>@@ -71,6 +71,7 @@ if ( $action eq 'create' ) {
> my $chapters = $cgi->param('chapters') || undef;
> my $patron_notes = $cgi->param('patron_notes') || undef;
> my $format = $cgi->param('format') || undef;
>+ my $toc_request = $cgi->param('toc_request');
> 
> try {
> my $ar = Koha::ArticleRequest->new(
>@@ -88,6 +89,7 @@ if ( $action eq 'create' ) {
> chapters => $chapters,
> patron_notes => $patron_notes,
> format => $format,
>+ toc_request => $toc_request ? 1 : 0,
> }
> )->request;
> } catch {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc
>index b2a25a0580..f3ab76e62c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc
>@@ -10,6 +10,7 @@
> <th class="article-request-volume">Volume</th>
> <th class="article-request-issue">Issue</th>
> <th class="article-request-date">Date</th>
>+ <th class="article-request-toc">TOC</th>
> <th class="article-request-pages">Pages</th>
> <th class="article-request-chapters">Chapters</th>
> <th class="article-request-notes">Notes</th>
>@@ -55,6 +56,10 @@
> [% ar.date | html %]
> </td>
> 
>+ <td class="article-request-toc">
>+ [% IF ar.toc_request %]Yes[% END %]
>+ </td>
>+
> <td class="article-request-pages">
> [% ar.pages | html %]
> </td>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
>index 0e4301e860..44a14123bc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
>@@ -353,6 +353,7 @@
> 
> </td>
> <td class="ar-request">
>+ [% IF ar.toc_request %] Include TOC [% END %]
> [% IF ar.title %] Title: [% ar.title | html %] [% END %]
> [% IF ar.author %] Author: [% ar.author | html %] [% END %]
> [% IF ar.volume %] Volume: [% ar.volume | html %] [% END %]
>@@ -456,6 +457,7 @@
> 
> </td>
> <td class="ar-request">
>+ [% IF ar.toc_request %] Include TOC [% END %]
> [% IF ar.title %] Title: [% ar.title | html %] [% END %]
> [% IF ar.author %] Author: [% ar.author | html %] [% END %]
> [% IF ar.volume %] Volume: [% ar.volume | html %] [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>index 7c2ea0fdb1..40b06282b2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt
>@@ -176,6 +176,11 @@
> <input type="text" name="date" id="date" size="50"/>
> </li>
> 
>+ <li>
>+ <label for="toc_request">Table of contents:</label>
>+ <input type="checkbox" name="toc_request" value="1"/>
>+ </li>
>+
> <li>
> <label for="pages">Pages:</label>
> <input type="text" name="pages" id="pages" size="50"/>
>@@ -297,6 +302,7 @@
> <th>Volume</th>
> <th>Issue</th>
> <th>Date</th>
>+ <th>TOC</th>
> <th>Pages</th>
> <th>Chapters</th>
> <th>Patron notes</th>
>@@ -316,6 +322,7 @@
> <td>[% ar.volume | html %]</td>
> <td>[% ar.issue | html %]</td>
> <td>[% ar.date | html %]</td>
>+ <td>[% IF ar.toc_request %]Yes[% END %]</td>
> <td>[% ar.pages | html %]</td>
> <td>[% ar.chapters | html %]</td>
> <td>[% ar.patron_notes | html %]</td>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
>index 9dad25f038..d30d7a1197 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt
>@@ -106,6 +106,11 @@
> [% END %]
> </li>
> 
>+ <li>
>+ <label for="toc_request">Table of contents:</label>
>+ <input type="checkbox" name="toc_request" value="1"/>
>+ </li>
>+
> <li>
> [% IF mandatory_fields.search('pages') %]
> <label for="pages" class="required">Pages:</label>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 730400e7e1..da736d7094 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -777,6 +777,7 @@
> <th class="article-request-volume">Volume</th>
> <th class="article-request-issue">Issue</th>
> <th class="article-request-date">Date</th>
>+ <th class="article-request-toc">TOC</th>
> <th class="article-request-pages">Pages</th>
> <th class="article-request-chapters">Chapters</th>
> <th class="article-request-patron-notes">Notes</th>
>@@ -822,6 +823,10 @@
> [% ar.date | html %]
> </td>
> 
>+ <td class="article-request-toc">
>+ [% IF ar.toc_request %]Yes[% END %]
>+ </td>
>+
> <td class="article-request-pages">
> [% ar.pages | html %]
> </td>
>diff --git a/opac/opac-request-article.pl b/opac/opac-request-article.pl
>index b6048cc8c2..1ef7184e0b 100755
>--- a/opac/opac-request-article.pl
>+++ b/opac/opac-request-article.pl
>@@ -62,6 +62,7 @@ if ( $action eq 'create' ) {
> my $chapters = $cgi->param('chapters') || undef;
> my $patron_notes = $cgi->param('patron_notes') || undef;
> my $format = $cgi->param('format') || undef;
>+ my $toc_request = $cgi->param('toc_request');
> 
> 
> my $success;
>@@ -82,6 +83,7 @@ if ( $action eq 'create' ) {
> chapters => $chapters,
> patron_notes => $patron_notes,
> format => $format,
>+ toc_request => $toc_request ? 1 : 0,
> }
> )->request;
> $success = 1;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29093: 125190 | 125191 | 125192 | 125288 | 125289 | 125290 | 125448 | 125449 | 125450 | 125772 | 125773 | 125774 | 125775 | 125787 | 125788 | 125789 | 125790 | 125791 | 125792