Bugzilla – Attachment 125783 Details for
Bug 29182
ArticleRequest status changing methods calling SUPER::store
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29182: (follow-up) Simplify Koha::ArticleRequest->store
Bug-29182-follow-up-Simplify-KohaArticleRequest-st.patch (text/plain), 907 bytes, created by
Tomás Cohen Arazi (tcohen)
on 2021-10-06 12:11:07 UTC
(
hide
)
Description:
Bug 29182: (follow-up) Simplify Koha::ArticleRequest->store
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-10-06 12:11:07 UTC
Size:
907 bytes
patch
obsolete
>From ce4277b540cba362a1bcb05c39f35e88129d5642 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 6 Oct 2021 09:10:38 -0300 >Subject: [PATCH] Bug 29182: (follow-up) Simplify Koha::ArticleRequest->store > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ArticleRequest.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm >index 2d7f5596da..be4a895e2e 100644 >--- a/Koha/ArticleRequest.pm >+++ b/Koha/ArticleRequest.pm >@@ -200,12 +200,12 @@ will have notifications sent. > > sub store { > my ($self) = @_; >- if ( $self->in_storage ) { >- return $self->SUPER::store; >- } else { >+ >+ if ( !$self->in_storage ) { > $self->created_on( dt_from_string() ); >- return $self->SUPER::store; > } >+ >+ return $self->SUPER::store; > } > > =head2 Internal methods >-- >2.32.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=125783">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29182
:
125779
|
125780
|
125783
|
125784
|
125785
|
125786
|
125869
|
125871
|
125872
|
125873
|
125874