Attachment 125786 Details for Bug 29182 – Bug 29182: (follow-up) Simplify Koha::ArticleRequest->store

[patch] Bug 29182: (follow-up) Simplify Koha::ArticleRequest->store

Bug-29182-follow-up-Simplify-KohaArticleRequest-st.patch (text/plain), 1005 bytes, created by Marcel de Rooy on 2021-10-06 12:16:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-10-06 12:16:14 UTC

Size: 1005 bytes

patch

obsolete

>From 0e830d9b66813e181d89c563dd3f32cd3008e158 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Wed, 6 Oct 2021 09:10:38 -0300
>Subject: [PATCH] Bug 29182: (follow-up) Simplify Koha::ArticleRequest->store
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/ArticleRequest.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm
>index 2d7f5596da..be4a895e2e 100644
>--- a/Koha/ArticleRequest.pm
>+++ b/Koha/ArticleRequest.pm
>@@ -200,12 +200,12 @@ will have notifications sent.
> 
> sub store {
>     my ($self) = @_;
>-    if ( $self->in_storage ) {
>-        return $self->SUPER::store;
>-    } else {
>+
>+    if ( !$self->in_storage ) {
>         $self->created_on( dt_from_string() );
>-        return $self->SUPER::store;
>     }
>+
>+    return $self->SUPER::store;
> }
> 
> =head2 Internal methods
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29182: 125779 | 125780 | 125783 | 125784 | 125785 | 125786 | 125869 | 125871 | 125872 | 125873 | 125874