Attachment 125799 Details for Bug 29152 – Bug 29152: Change default value for SearchLimitLibrary to 'homebranch'

[patch] Bug 29152: Change default value for SearchLimitLibrary to 'homebranch'

Bug-29152-Change-default-value-for-SearchLimitLibr.patch (text/plain), 3.06 KB, created by Nick Clemens (kidclamp) on 2021-10-06 12:58:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-10-06 12:58:38 UTC

Size: 3.06 KB

patch

obsolete

>From 23f1e5aaa51138da0a62badb03978a4f54b77bab Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 6 Oct 2021 12:56:39 +0000
>Subject: [PATCH] Bug 29152: Change default value for SearchLimitLibrary to
> 'homebranch'
>
>Behvaiour before this option was added was 'homebranch'
>We should preserve this rather than introduce a change
>
>No atomic update added as liobraries may have already set/changed the value,
>but safer to default to previous behvaiour
>---
> installer/data/mysql/mandatory/sysprefs.sql | 2 +-
> installer/data/mysql/updatedatabase.pl      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index d797c074ae..ca38d537b6 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -593,7 +593,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('SCOUserCSS','',NULL,'Add CSS to be included in the SCO module in an embedded <style> tag.','free'),
> ('SCOUserJS','',NULL,'Define custom javascript for inclusion in the SCO module','free'),
> ('SearchEngine','Zebra','Elasticsearch|Zebra','Search Engine','Choice'),
>-('SearchLimitLibrary', 'both', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice'),
>+('SearchLimitLibrary', 'homebranch', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice'),
> ('SearchMyLibraryFirst','0',NULL,'If ON, OPAC searches return results limited by the user\'s library by default if they are logged in','YesNo'),
> ('SearchWithISBNVariations','0',NULL,'If enabled, search on all variations of the ISBN','YesNo'),
> ('SelfCheckAllowByIPRanges','',NULL,'(Leave blank if not used. Use ranges or simple ip addresses separated by spaces, like <code>192.168.1.1 192.168.0.0/24</code>.)','Short'),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 4f89a31f60..3c82420d36 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -24191,7 +24191,7 @@ if( CheckVersion( $DBversion ) ) {
> $DBversion = '20.12.00.045';
> if( CheckVersion( $DBversion ) ) {
>     $dbh->do(q{
>-        INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SearchLimitLibrary', 'both', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice')
>+        INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SearchLimitLibrary', 'homebranch', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice')
>     });
> 
>     NewVersion( $DBversion, 21249, "Adding new system preference SearchLimitLibrary" );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29152: 125799 | 127180