Attachment 125816 Details for Bug 29114 – Bug 29114: (QA follow-up) Carriage return is whitespace too

[patch] Bug 29114: (QA follow-up) Carriage return is whitespace too

Bug-29114-QA-follow-up-Carriage-return-is-whitespa.patch (text/plain), 1.08 KB, created by Marcel de Rooy on 2021-10-06 13:44:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-10-06 13:44:23 UTC

Size: 1.08 KB

patch

obsolete

>From 7940ef689dfb51c4a240b251e37aaeffec8ddece Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 6 Oct 2021 13:43:15 +0000
>Subject: [PATCH] Bug 29114: (QA follow-up) Carriage return is whitespace too
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> virtualshelves/shelves.pl | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl
>index 1ac4d592e9..b79d536acb 100755
>--- a/virtualshelves/shelves.pl
>+++ b/virtualshelves/shelves.pl
>@@ -155,7 +155,6 @@ if ( $op eq 'add_form' ) {
>                 my @barcodes = split /\n/, $barcodes; # Entries are effectively passed in as a <cr> separated list
>                 foreach my $barcode (@barcodes){
>                     $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace
>-                    $barcode =~ s/\r$//; # strip any naughty return chars
>                     next if $barcode eq '';
>                     my $item = Koha::Items->find({barcode => $barcode});
>                     if ( $item ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29114: 125369 | 125752 | 125753 | 125815 | 125816 | 126867 | 126868 | 126896 | 127075 | 127098 | 137687 | 137773