Bugzilla – Attachment 125818 Details for
Bug 27526
Remove Mod/AddItemFromMarc from additem.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27526: Fix perlcritic in tests
Bug-27526-Fix-perlcritic-in-tests.patch (text/plain), 1.07 KB, created by
Jonathan Druart
on 2021-10-06 13:56:13 UTC
(
hide
)
Description:
Bug 27526: Fix perlcritic in tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-10-06 13:56:13 UTC
Size:
1.07 KB
patch
obsolete
>From 92250a22cd236c3d169f9c4051f29dcaef578183 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 6 Oct 2021 15:53:47 +0200 >Subject: [PATCH] Bug 27526: Fix perlcritic in tests > >Problem while critiquing "t/db_dependent/Koha/Item.t": Can't parse code: Encountered unexpected character '195' > >non-ascii chars must be quoted when used as hash keys >--- > t/db_dependent/Koha/Item.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index e1274a414fd..617dc8a9027 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -1137,8 +1137,8 @@ subtest 'columns_to_str' => sub { > my $s = $item->columns_to_str; > is( $s->{itemlost}, 'Lost' ); > is( $s->{dateaccessioned}, '2020-12-15'); >- is( $s->{é}, 'value é'); >- is( $s->{è}, $library->branchname ); >+ is( $s->{'é'}, 'value é'); >+ is( $s->{'è'}, $library->branchname ); > > $cache->clear_from_cache("MarcStructure-0-"); > $cache->clear_from_cache("MarcStructure-1-"); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27526
:
115679
|
115680
|
116006
|
117806
|
117807
|
117808
|
121589
|
121590
|
121591
|
122288
|
122318
|
122655
|
122656
|
122657
|
122658
|
122676
|
122677
|
122681
|
122682
|
122694
|
122695
|
122696
|
122946
|
122947
|
122948
|
122949
|
122950
|
122951
|
122952
|
122953
|
122954
|
122957
|
122958
|
122959
|
122974
|
123006
|
123007
|
123110
|
123329
|
123372
|
123415
|
123757
|
123758
|
123759
|
123760
|
123761
|
123762
|
123763
|
123764
|
123765
|
123766
|
123767
|
123768
|
123769
|
123770
|
123771
|
123772
|
125069
|
125605
|
125606
|
125607
|
125608
|
125609
|
125610
|
125611
|
125612
|
125613
|
125614
|
125615
|
125616
|
125617
|
125618
|
125619
|
125620
| 125818 |
125839
|
125863
|
126034
|
126051
|
126143
|
126144
|
126393
|
127025
|
127032