Bugzilla – Attachment 125899 Details for
Bug 28876
No renewal before advisory text not wrapped in selector
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28876: No renewal before advisory text not wrapped in selector
Bug-28876-No-renewal-before-advisory-text-not-wrap.patch (text/plain), 6.98 KB, created by
Owen Leonard
on 2021-10-07 16:58:11 UTC
(
hide
)
Description:
Bug 28876: No renewal before advisory text not wrapped in selector
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-10-07 16:58:11 UTC
Size:
6.98 KB
patch
obsolete
>From dda30dcf6840c5e109b6386d3ee3795c6b95376b Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 7 Oct 2021 16:44:47 +0000 >Subject: [PATCH] Bug 28876: No renewal before advisory text not wrapped in > selector > >This patch adds some more <span>s to the user summary page in the OPAC >so that information about renewal status can be targeted with CSS or JS. >It adds each <span> with a "usr-msg" class for general styling and a >specific class for each renewal message, e.g. > ><span class="usr-msg no-renew-hold">Not renewable <span >class="renewals">(on hold)</span></span> > >These classes are added: > >- no-renew-hold - Not renewable (on hold) >- no-renew-too-many - Not renewable (too many renwals) >- no-renew-unseen - Item must be renewed at the library >- no-renew-overdue - Not allowed (overdue) >- no-renew-too-late - No longer renewable >- auto-renew-fines - Automatic renewal failed, you have unpaid fines >- auto-renew-expired - Automatic renewal failed, your account is expired >- no-renewal-before - No renewal before [date] >- automatic-renewal - Automatic renewal > >To test, apply the patch and try to locate or set up a patron to have >multiple checkouts with multiple renewal conditions: > >- On hold >- Too many renewals >- Overdues (if OverduesBlockRenewing is on) > >...etc. > >In the OPAC, log in and view the table of checkouts on the "your >summary" page. Confirm that messages in the "Renew" column are marked up >correctly. >--- > .../bootstrap/en/modules/opac-user.tt | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 3c6bb1206d..0830439307 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -392,17 +392,17 @@ > [% END %] > )</span> > [% ELSIF ( ISSUE.on_reserve ) %] >- Not renewable <span class="renewals">(on hold)</span> >+ <span class="usr-msg no-renew-hold">Not renewable <span class="renewals">(on hold)</span></span> > [% ELSIF ( ISSUE.too_many ) %] >- Not renewable >+ <span class="usr-msg no-renew-too-many">Not renewable</span> > [% ELSIF ( ISSUE.too_unseen ) %] >- Item must be renewed at the library. [% ISSUE.renewsleft | html %] renewals remaining >+ <span class="usr-msg no-renew-unseen">Item must be renewed at the library. [% ISSUE.renewsleft | html %] renewals remaining</span> > [% ELSIF ( ISSUE.norenew_overdue ) %] >- Not allowed <span class="renewals">(overdue)</span> >+ <span class="usr-msg no-renew-overdue">Not allowed <span class="renewals">(overdue)</span></span> > [% ELSIF ( ISSUE.auto_too_late ) %] >- No longer renewable >+ <span class="usr-msg no-renew-too-lage">No longer renewable</span> > [% ELSIF ISSUE.auto_too_much_oweing %] >- Automatic renewal failed, you have unpaid fines. >+ <span class="usr-msg auto-renew-fines">Automatic renewal failed, you have unpaid fines.</span> > <span class="renewals">( > [% ISSUE.renewsleft | html %] of [% ISSUE.renewsallowed | html %] renewals remaining > [% IF Koha.Preference('UnseenRenewals') && ISSUE.unseenallowed %] >@@ -410,7 +410,7 @@ > [% END %] > )</span> > [% ELSIF ISSUE.auto_account_expired %] >- Automatic renewal failed, your account is expired. >+ <span class="usr-msg auto-renew-expired">Automatic renewal failed, your account is expired.</span> > <span class="renewals">( > [% ISSUE.renewsleft | html %] of [% ISSUE.renewsallowed | html %] renewals remaining > [% IF Koha.Preference('UnseenRenewals') && ISSUE.unseenallowed %] >@@ -418,7 +418,7 @@ > [% END %] > )</span> > [% ELSIF ( ISSUE.too_soon ) %] >- No renewal before [% ISSUE.soonestrenewdate | html %] >+ <span class="usr-msg no-renewal-before">No renewal before [% ISSUE.soonestrenewdate | html %]</span> > <span class="renewals">( > [% ISSUE.renewsleft | html %] of [% ISSUE.renewsallowed | html %] renewals remaining > [% IF Koha.Preference('UnseenRenewals') && ISSUE.unseenallowed %] >@@ -426,7 +426,7 @@ > [% END %] > )</span> > [% ELSIF ( ISSUE.auto_renew || ISSUE.auto_too_soon ) %] >- Automatic renewal >+ <span class="usr-msg automatic-renewal">Automatic renewal</span> > <span class="renewals">( > [% ISSUE.renewsleft | html %] of [% ISSUE.renewsallowed | html %] renewals remaining > [% IF Koha.Preference('UnseenRenewals') && ISSUE.unseenallowed %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28876
:
125899
|
125900
|
128551