Attachment 125928 Details for Bug 28211 – Bug 28211: (QA follow-up) POD changes

[patch] Bug 28211: (QA follow-up) POD changes

Bug-28211-QA-follow-up-POD-changes.patch (text/plain), 2.35 KB, created by Marcel de Rooy on 2021-10-08 07:13:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-10-08 07:13:53 UTC

Size: 2.35 KB

patch

obsolete

>From ba4d2f730ee86e3dbe361af25de9d3c9f1cfaa6a Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 8 Oct 2021 07:00:10 +0000
>Subject: [PATCH] Bug 28211: (QA follow-up) POD changes
>Content-Type: text/plain; charset=utf-8
>
>[1] Resolving qa warn on POD coverage.
>[2] Adding a line about the passing refs-tric.
>[3] Removing an outdated line on available methods.
>[4] Removing POD section for after_hold_create. Strayed.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Plugins.pm | 34 ++++++++--------------------------
> 1 file changed, 8 insertions(+), 26 deletions(-)
>
>diff --git a/Koha/Plugins.pm b/Koha/Plugins.pm
>index fa4d235287..033ba28376 100644
>--- a/Koha/Plugins.pm
>+++ b/Koha/Plugins.pm
>@@ -44,6 +44,10 @@ BEGIN {
> 
> Koha::Plugins - Module for loading and managing plugins.
> 
>+=head2 new
>+
>+Constructor
>+
> =cut
> 
> sub new {
>@@ -62,6 +66,9 @@ Calls a plugin method for all enabled plugins
> 
>     @responses = Koha::Plugins->call($method, @args)
> 
>+Note: Pass your arguments as refs, when you want subsequent plugins to use the value
>+updated by preceding plugins, provided that these plugins support that.
>+
> =cut
> 
> sub call {
>@@ -96,7 +103,6 @@ method or metadata value.
>     });
> 
> The method and metadata parameters are optional.
>-Available methods currently are: 'report', 'tool', 'to_marc', 'edifact'.
> If you pass multiple keys in the metadata hash, all keys must match.
> 
> =cut
>@@ -168,7 +174,7 @@ This method iterates through all plugins physically present on a system.
> For each plugin module found, it will test that the plugin can be loaded,
> and if it can, will store its available methods in the plugin_methods table.
> 
>-NOTE: We re-load all plugins here as a protective measure in case someone
>+NOTE: We reload all plugins here as a protective measure in case someone
> has removed a plugin directly from the system without using the UI
> 
> =cut
>@@ -220,30 +226,6 @@ sub InstallPlugins {
> 1;
> __END__
> 
>-=head1 AVAILABLE HOOKS
>-
>-=head2 after_hold_create
>-
>-=head3 Parameters
>-
>-=over
>-
>-=item * C<$hold> - A Koha::Hold object that has just been inserted in database
>-
>-=back
>-
>-=head3 Return value
>-
>-None
>-
>-=head3 Example
>-
>-    sub after_hold_create {
>-        my ($self, $hold) = @_;
>-
>-        warn "New hold for borrower " . $hold->borrower->borrowernumber;
>-    }
>-
> =head1 AUTHOR
> 
> Kyle M Hall <kyle.m.hall@gmail.com>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28211: 120120 | 120875 | 120882 | 120883 | 122425 | 122426 | 122427 | 125892 | 125926 | 125927 | 125928 | 126274 | 126471 | 126497