Attachment 125938 Details for Bug 24698 – Bug 24698: (QA follow-up) Don't specify select element's size if it is 1

[patch] Bug 24698: (QA follow-up) Don't specify select element's size if it is 1

Bug-24698-QA-follow-up-Dont-specify-select-element.patch (text/plain), 2.29 KB, created by George Veranis on 2021-10-08 08:17:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: George Veranis

Created: 2021-10-08 08:17:20 UTC

Size: 2.29 KB

patch

obsolete

>From 64eadc6cc1b877170eb92821f8ed8a7f63d8f53b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Sun, 3 Oct 2021 12:21:52 +0000
>Subject: [PATCH] Bug 24698: (QA follow-up) Don't specify select element's size
> if it is 1
>
>This is to make the QA script happy, in order to not to break
>Bootstrap CSS rules, see Bug 28066 for more info
>
>Signed-off-by: George Veranis <gveranis@dataly.gr>
>---
> .../value_builder/unimarc_leader_authorities.tt           | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_leader_authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_leader_authorities.tt
>index 3a4962c23d..6f41fd9490 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_leader_authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_leader_authorities.tt
>@@ -15,7 +15,7 @@
>     <tr>
>         <td><label for="f5">5- Record status</label></td>
>         <td>
>-            <select name="f5" id="f5" size="1">
>+            <select name="f5" id="f5">
>             [% IF ( f5c ) %]
>                 <option value="c" selected="selected">c - Corrected or revised</option>
>             [% ELSE %]
>@@ -37,7 +37,7 @@
>     <tr>
>         <td><label for="f6">6- Type of record</label></td>
>         <td>
>-            <select name="f6" id="f6" size="1">
>+            <select name="f6" id="f6">
>             [% IF ( f6x ) %]
>                 <option value="x" selected="selected">x - Authority entry record</option>
>             [% ELSE %]
>@@ -67,7 +67,7 @@
>     <tr>
>         <td><label for="f9">9- Type of entity</label></td>
>         <td>
>-            <select name="f9" id="f9" size="1">
>+            <select name="f9" id="f9">
>             [% IF ( f9 ) %]
>                 <option value=" " selected="selected"> - Series</option>
>             [% ELSE %]
>@@ -157,7 +157,7 @@
>     <tr>
>         <td><label for="f17">17- Encoding level</label></td>
>         <td>
>-            <select name="f17" id="f17" size="1">
>+            <select name="f17" id="f17">
>                 [% IF ( f17space ) %]
>                     <option value=" " selected="selected"> - Full</option>
>                 [% ELSE %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24698: 118186 | 124437 | 125669 | 125670 | 125671 | 125672 | 125673 | 125674 | 125675 | 125676 | 125677 | 125678 | 125679 | 125680 | 125929 | 125930 | 125931 | 125932 | 125933 | 125934 | 125935 | 125936 | 125937 | 125938 | 125939 | 125940 | 125998 | 125999 | 126000 | 126001 | 126002 | 126003 | 126004 | 126005 | 126006 | 126007 | 126008 | 126009 | 126010