Bugzilla – Attachment 125960 Details for
Bug 15812
Checkout search with too many results (single character search) causes poor performance or timeout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15812: (follow-up) Enable click cell to select
Bug-15812-follow-up-Enable-click-cell-to-select.patch (text/plain), 2.67 KB, created by
Nick Clemens (kidclamp)
on 2021-10-08 13:16:08 UTC
(
hide
)
Description:
Bug 15812: (follow-up) Enable click cell to select
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-10-08 13:16:08 UTC
Size:
2.67 KB
patch
obsolete
>From 438a69e976dd9a700adbe683a9b34f6f80199968 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 1 Oct 2021 12:25:20 +0100 >Subject: [PATCH] Bug 15812: (follow-up) Enable click cell to select > >This patch adds handling to allow clicking anywhere in the table cell to >select/deselect the patron > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 7 +++++++ > .../prog/en/modules/members/tables/members_results.tt | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index e20bd380c0..6195367695 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -556,6 +556,13 @@ > return false; > } > >+ $('#memberresultst tbody').on('click','td',function(e){ >+ var $checkbox = $(this).find("input[type=checkbox]"); >+ if (e.target.type != "checkbox") { >+ $checkbox.prop('checked', !$checkbox.prop("checked")); >+ } >+ }); >+ > // User has clicked on the Clear button > function clearFilters(redraw) { > $("#searchform select").val(''); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >index eeb0da6742..5e219d2c9f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt >@@ -13,7 +13,7 @@ > { > [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %] > "dt_borrowernumber": >- "<input type='checkbox' id='check[% data.borrowernumber | html %]' class='selection' name='borrowernumber' value='[% data.borrowernumber | html %]' />", >+ "<label for='check[% data.borrowernumber | html %]' class='content_hidden'>Select patron</label><input type='checkbox' id='check[% data.borrowernumber | html %]' class='selection' name='borrowernumber' value='[% data.borrowernumber | html %]' />", > [% END %] > "dt_cardnumber": > "[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]<a href='/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% data.borrowernumber | html %]' title='Checkout'>[% data.cardnumber | html | $To %]</a>[% ELSE %][% data.cardnumber | html | $To %][% END %]", >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15812
:
125224
|
125234
|
125413
|
125489
|
125490
|
125580
|
125582
|
125583
|
125597
|
125604
|
125621
|
125622
|
125623
|
125624
|
125957
|
125958
|
125959
| 125960