Attachment 12597 Details for Bug 8843 – [SIGNED-OFF] Bug 8843 - Cannot export bibliographic records by call number

[patch] [SIGNED-OFF] Bug 8843 - Cannot export bibliographic records by call number

SIGNED-OFF-Bug-8843---Cannot-export-bibliographic-.patch (text/plain), 1.47 KB, created by Nicole C. Engard on 2012-09-28 16:40:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-09-28 16:40:38 UTC

Size: 1.47 KB

patch

obsolete

>From 6ef76453a7b36631a2ad31be7d4556a2ac09858c Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 28 Sep 2012 10:48:16 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8843 - Cannot export bibliographic records by call number
>
>When building the query for exports by call number the script
>has the logic reversed. It tries to select records with call
>numbers less than the starting call number and greater than
>the ending call number. This should be reversed.
>
>To test, test an export in an unpatched system. An export by
>call number will return an empty file. After applying the patch
>an export by call number should give valid results.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>Works as expected.
>---
> tools/export.pl |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tools/export.pl b/tools/export.pl
>index a4eb6e9..c7a8fd8 100755
>--- a/tools/export.pl
>+++ b/tools/export.pl
>@@ -538,12 +538,12 @@ sub construct_query {
>             }
> 
>             if ($start_callnumber) {
>-                $sql_query .= " AND itemcallnumber <= ? ";
>+                $sql_query .= " AND itemcallnumber >= ? ";
>                 push @sql_params, $start_callnumber;
>             }
> 
>             if ($end_callnumber) {
>-                $sql_query .= " AND itemcallnumber >= ? ";
>+                $sql_query .= " AND itemcallnumber <= ? ";
>                 push @sql_params, $end_callnumber;
>             }
>             if ($start_accession) {
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 8843: 12592 | 12597 | 13613 | 13646