Attachment 125972 Details for Bug 3142 – Bug 3142: Add test for the circ rule

[patch] Bug 3142: Add test for the circ rule

Bug-3142-Add-test-for-the-circ-rule.patch (text/plain), 1.76 KB, created by Nick Clemens (kidclamp) on 2021-10-08 14:31:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-10-08 14:31:37 UTC

Size: 1.76 KB

patch

obsolete

>From b536d021383770157b98d88e7d91e6f5ada2d026 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 5 Oct 2021 14:30:49 +0200
>Subject: [PATCH] Bug 3142: Add test for the circ rule
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> t/db_dependent/Koha/Items.t | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t
>index d8aed21754..80e2b7b604 100755
>--- a/t/db_dependent/Koha/Items.t
>+++ b/t/db_dependent/Koha/Items.t
>@@ -1510,7 +1510,7 @@ subtest 'can_be_transferred' => sub {
> };
> 
> subtest 'filter_by_for_hold' => sub {
>-    plan tests => 8;
>+    plan tests => 9;
> 
>     my $biblio = $builder->build_sample_biblio;
>     is( $biblio->items->filter_by_for_hold->count, 0, 'no item yet' );
>@@ -1536,6 +1536,23 @@ subtest 'filter_by_for_hold' => sub {
>     t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 1);
>     is( $biblio->items->filter_by_for_hold->count, 6, '6 items for hold - damaged if AllowHoldsOnDamagedItems' );
> 
>+    my $not_holdable_itemtype = $builder->build_object({ class => 'Koha::ItemTypes' })->itemtype;
>+    $builder->build_sample_item(
>+        {
>+            biblionumber => $biblio->biblionumber,
>+            itype        => $not_holdable_itemtype,
>+        }
>+    );
>+    Koha::CirculationRules->set_rule(
>+        {
>+            branchcode   => undef,
>+            itemtype     => $not_holdable_itemtype,
>+            rule_name    => 'holdallowed',
>+            rule_value   => 'not_allowed',
>+        }
>+    );
>+    is( $biblio->items->filter_by_for_hold->count, 6, '6 items for hold - holdallowed=not_allowed' );
>+
>     $biblio->delete;
> };
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 3142: 122284 | 122285 | 122286 | 122287 | 122314 | 122315 | 122316 | 122317 | 125727 | 125728 | 125729 | 125730 | 125732 | 125733 | 125734 | 125942 | 125943 | 125944 | 125945 | 125946 | 125947 | 125948 | 125949 | 125950 | 125951 | 125956 | 125967 | 125968 | 125969 | 125970 | 125971 | 125972 | 125973 | 125974 | 125975 | 125976 | 125977