Bugzilla – Attachment 125974 Details for
Bug 3142
Standardize how OPAC and staff determine requestability
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3142: (QA follow-up) Cosmetic changes
Bug-3142-QA-follow-up-Cosmetic-changes.patch (text/plain), 1.57 KB, created by
Nick Clemens (kidclamp)
on 2021-10-08 14:31:45 UTC
(
hide
)
Description:
Bug 3142: (QA follow-up) Cosmetic changes
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-10-08 14:31:45 UTC
Size:
1.57 KB
patch
obsolete
>From 4065f406b7e7e741ec8b378497e1379ffa436ecb Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 8 Oct 2021 08:31:52 +0000 >Subject: [PATCH] Bug 3142: (QA follow-up) Cosmetic changes > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Items.pm | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/Koha/Items.pm b/Koha/Items.pm >index ced8653b46..629a2147cd 100644 >--- a/Koha/Items.pm >+++ b/Koha/Items.pm >@@ -43,9 +43,9 @@ Koha::Items - Koha Item object set class > > my $filtered_items = $items->filter_by_for_hold; > >-Return the items of the set that are *potentially* holdable >+Return the items of the set that are *potentially* holdable. > >-Caller has the responsability to call C4::Reserves::CanItemBeReserved before >+Caller has the responsibility to call C4::Reserves::CanItemBeReserved before > placing a hold on one of those items. > > =cut >@@ -66,9 +66,8 @@ sub filter_by_for_hold { > { > itemlost => 0, > withdrawn => 0, >- notforloan => { '<=' => 0 } >- , # items with negative or zero notforloan value are holdable >- ( ! C4::Context->preference('AllowHoldsOnDamagedItems' ) ? ( damaged => 0 ) : () ), >+ notforloan => { '<=' => 0 }, # items with negative or zero notforloan value are holdable >+ ( C4::Context->preference('AllowHoldsOnDamagedItems' ) ? () : ( damaged => 0 ) ), > itype => { -not_in => \@hold_not_allowed_itypes }, > } > ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3142
:
122284
|
122285
|
122286
|
122287
|
122314
|
122315
|
122316
|
122317
|
125727
|
125728
|
125729
|
125730
|
125732
|
125733
|
125734
|
125942
|
125943
|
125944
|
125945
|
125946
|
125947
|
125948
|
125949
|
125950
|
125951
|
125956
|
125967
|
125968
|
125969
|
125970
|
125971
|
125972
|
125973
| 125974 |
125975
|
125976
|
125977