Attachment 125996 Details for Bug 29111 – Bug 29111: Remove dead code from acqui/addorderiso2709.pl

[patch] Bug 29111: Remove dead code from acqui/addorderiso2709.pl

Bug-29111-Remove-dead-code-from-acquiaddorderiso27.patch (text/plain), 1.52 KB, created by Joonas Kylmälä on 2021-10-10 08:44:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-10-10 08:44:43 UTC

Size: 1.52 KB

patch

obsolete

>From 75f6a43bd642c37840235cb4471864658a0d7fab Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Sun, 26 Sep 2021 08:01:51 +0000
>Subject: [PATCH] Bug 29111: Remove dead code from acqui/addorderiso2709.pl
>
>Test plan:
> 1) open acqui/addorderiso2709.pl in your code editor and make sure
> nothing references $item in the if block where it was removed from
>
>Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> acqui/addorderiso2709.pl | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index 404c3334bd..47c2ff2cca 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -378,12 +378,6 @@ if ($op eq ""){
>             my @serials      = $input->multi_param('serial');
>             my @ind_tag   = $input->multi_param('ind_tag');
>             my @indicator = $input->multi_param('indicator');
>-            my $item;
>-            push @{ $item->{tags} },         $tags[0];
>-            push @{ $item->{subfields} },    $subfields[0];
>-            push @{ $item->{field_values} }, $field_values[0];
>-            push @{ $item->{ind_tag} },      $ind_tag[0];
>-            push @{ $item->{indicator} },    $indicator[0];
>             my $xml = TransformHtmlToXml( \@tags, \@subfields, \@field_values, \@indicator, \@ind_tag );
>             my $record = MARC::Record::new_from_xml( $xml, 'UTF-8' );
>             for (my $qtyloop=1;$qtyloop <= $c_quantity;$qtyloop++) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29111: 125311 | 125312 | 125313 | 125601 | 125602 | 125603 | 125652 | 125653 | 125654 | 125996 | 125997