Attachment 125999 Details for Bug 24698 – Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced

[patch] Bug 24698: (QA follow-up) Fix errors caused by more strict exports being introduced

Bug-24698-QA-follow-up-Fix-errors-caused-by-more-s.patch (text/plain), 1.40 KB, created by Joonas Kylmälä on 2021-10-10 09:06:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2021-10-10 09:06:02 UTC

Size: 1.40 KB

patch

obsolete

>From 43bd3c5df9e39d34d8c74badc5164641dc1bb4b9 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
>Date: Sun, 3 Oct 2021 11:51:22 +0000
>Subject: [PATCH] Bug 24698: (QA follow-up) Fix errors caused by more strict
> exports being introduced
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The original patch "Bug 24698: Add plugin and template files for
>unimarc authority leader" doesn't work without explictly importing the
>methods from C4::Auth and C4::Output due to the default exports being
>changed in those modules after the patch was made.
>
>Signed-off-by: George Veranis <gveranis@dataly.gr>
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@iki.fi>
>---
> cataloguing/value_builder/unimarc_leader_authorities.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_leader_authorities.pl b/cataloguing/value_builder/unimarc_leader_authorities.pl
>index becdc574af..4953a7e943 100644
>--- a/cataloguing/value_builder/unimarc_leader_authorities.pl
>+++ b/cataloguing/value_builder/unimarc_leader_authorities.pl
>@@ -20,10 +20,10 @@
> use Modern::Perl;
> 
> use Koha::Util::FrameworkPlugin qw(wrapper);
>-use C4::Auth;
>+use C4::Auth qw( get_template_and_user );
> use CGI qw ( -utf8 );
> use C4::Context;
>-use C4::Output;
>+use C4::Output qw( output_html_with_http_headers );
> 
> 
> sub plugin_javascript {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24698: 118186 | 124437 | 125669 | 125670 | 125671 | 125672 | 125673 | 125674 | 125675 | 125676 | 125677 | 125678 | 125679 | 125680 | 125929 | 125930 | 125931 | 125932 | 125933 | 125934 | 125935 | 125936 | 125937 | 125938 | 125939 | 125940 | 125998 | 125999 | 126000 | 126001 | 126002 | 126003 | 126004 | 126005 | 126006 | 126007 | 126008 | 126009 | 126010