Attachment 126141 Details for Bug 28445 – Bug 28445: Fix subfields to blank

[patch] Bug 28445: Fix subfields to blank

Bug-28445-Fix-subfields-to-blank.patch (text/plain), 2.08 KB, created by Jonathan Druart on 2021-10-13 06:49:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-10-13 06:49:33 UTC

Size: 2.08 KB

patch

obsolete

>From 1cdcd7a0f26bf9c3aaacda518f520300636982ec Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 11 Oct 2021 15:46:05 +0200
>Subject: [PATCH] Bug 28445: Fix subfields to blank
>
>The value of the checkbox was not correct
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +-
> tools/batchMod.pl                                         | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>index 52f2c8faf0d..26e1f348a37 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>@@ -152,7 +152,7 @@
> 
>                     [% IF add_delete_checkbox %]
>                         [% UNLESS ( subfield.mandatory ) %]
>-                            <input type="checkbox" id="row[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]" title="Check to delete subfield [% subfield.subfield | html %]" name="disable_input" value="[% subfield.subfield | html %]" />
>+                            <input type="checkbox" id="row[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]" title="Check to delete subfield [% subfield.subfield | html %]" name="disable_input" value="[% kohafield | html %]" />
>                         [% ELSE %]
>                             <span class="required">Required</span>
>                         [% END %]
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index e5ba87cfbb8..81745c3e6f3 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -138,8 +138,7 @@ if ( $op eq "action" ) {
>                   . encode_utf8($attr)
>                   ;  # We need to deal correctly with encoding on subfield codes
> 
>-                if ( grep { $attr eq $_ } @subfields_to_blank ) {
>-
>+                if ( grep { $cgi_var_name eq $_ } @subfields_to_blank ) {
>                     # Empty this column
>                     $new_item_data->{$attr} = undef;
>                 }
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 28445: 121372 | 123221 | 123222 | 123223 | 123224 | 123225 | 123226 | 123227 | 123228 | 123229 | 123239 | 123240 | 125801 | 125802 | 125803 | 125804 | 125805 | 125808 | 125810 | 125811 | 125812 | 125817 | 125865 | 126046 | 126047 | 126136 | 126137 | 126138 | 126139 | 126140 | 126141 | 126142 | 126217 | 126218 | 126219 | 126223 | 126328 | 126329 | 126330 | 126331 | 126332 | 126333 | 126334 | 126335 | 126336 | 126337 | 126338 | 126339 | 126352 | 126353 | 126354 | 126355 | 126356 | 126357 | 126358 | 126359 | 126360 | 126361 | 126362 | 126363 | 126364 | 126365 | 126366 | 126367 | 126374 | 126375 | 126376 | 126377 | 126378 | 126379 | 126380 | 126381 | 126382 | 126383 | 126384 | 126385 | 126386 | 126387 | 126388 | 126389 | 127033 | 127037 | 127038 | 127039 | 128007 | 128008 | 128009