Bugzilla – Attachment 126145 Details for
Bug 29218
"hidden" class is not working for DT if column visibility button is used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29218: Rename .hidden class for DT visibility
Bug-29218-Rename-hidden-class-for-DT-visibility.patch (text/plain), 5.22 KB, created by
Jonathan Druart
on 2021-10-13 08:23:21 UTC
(
hide
)
Description:
Bug 29218: Rename .hidden class for DT visibility
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-10-13 08:23:21 UTC
Size:
5.22 KB
patch
obsolete
>From 03a0b0724c05eb2785e83605a895aba90d487480 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 13 Oct 2021 10:16:00 +0200 >Subject: [PATCH] Bug 29218: Rename .hidden class for DT visibility > >.hidden get the CSS that interferes with DT behaviour > >.hidden { > display: none !important; >} > >Test this patch with bug 28859. >--- > .../intranet-tmpl/prog/en/includes/columns_settings.inc | 1 + > .../prog/en/modules/reports/guided_reports_start.tt | 7 ++----- > .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 7 ++----- > 3 files changed, 5 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index a1d80ecbb6c..52f33742dc0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -134,6 +134,7 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { > { "targets": [ "string-sort" ], "type": "string" }, > { "targets": [ "anti-the" ], "type": "anti-the" }, > { "targets": [ "NoSort" ], "orderable": false, "searchable": false }, >+ { "targets": [ "NoVisible" ], "visible": false } > ]; > if ( new_parameters["aoColumnDefs"] === undefined ) { > new_parameters["aoColumnDefs"] = default_column_defs; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 1a4c2d9a3dd..2647ad323cc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -278,13 +278,13 @@ > [% IF (usecache) %] > <th>Cache expiry (seconds)</th> > [% ELSE %] >- <th class="hidden"> </th> >+ <th class="NoVisible">Cache expiry (seconds)</th> > [% END %] > <th>Saved results</th> > [% IF has_obsolete_reports %] > <th>Update</th> > [% ELSE %] >- <th class="hidden"> </th> >+ <th class="NoVisible">Update</th> > [% END %] > <th class="NoSort noExport">Actions</th> > </tr> >@@ -1733,9 +1733,6 @@ > 'bAutoWidth': false, > 'sPaginationType': 'full', > 'aaSorting': [[ 1, "asc" ]], >- 'aoColumnDefs': [ >- { "visible": false, "aTargets" : [ "hidden" ] } >- ], > 'oLanguage': { > 'sZeroRecords': _("No matching reports found") > }, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index d067e39624f..f60a917a9b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -202,7 +202,7 @@ > [% IF ( op == 'show' ) %] > <th class="NoSort"> </th> > [% ELSE %] >- <th class="hidden"> </th> >+ <th class="NoVisible"> </th> > [% END %] > <th>Card number</th> > <th>Surname</th> >@@ -236,7 +236,7 @@ > [% IF ( op == 'show' ) %] > <td> > [% ELSE %] >- <td class="hidden"> >+ <td class="NoVisible"> > [% END %] > <input type="checkbox" name="borrowernumber" value="[% borrower.borrowernumber | html %]" checked="checked" /> > </td> >@@ -427,9 +427,6 @@ > KohaTable("borrowerst", { > "order": [[ 1, "asc" ]], > "autoWidth": false, >- "columnDefs": [ >- { "visible": false, "targets" : [ "hidden" ] } >- ] > }, table_settings); > > $("#selectallbutton").click(function() { >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29218
:
126145
|
127029