Bugzilla – Attachment 12616 Details for
Bug 8849
Error log generated when not a demo system
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix error logging triggered by adding/editing/deleting tags on framework
0001-Bug-8849-Error-log-generated-when-not-a-demo-system.patch (text/plain), 2.17 KB, created by
Mark Tompsett
on 2012-10-01 09:18:11 UTC
(
hide
)
Description:
Fix error logging triggered by adding/editing/deleting tags on framework
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2012-10-01 09:18:11 UTC
Size:
2.17 KB
patch
obsolete
>From c3faf3e71eed3581a089d77fb5a84f32ccda14ab Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 1 Oct 2012 16:29:22 +0800 >Subject: [PATCH] Bug 8849 - Error log generated when not a demo system >Content-Type: text/plain; charset="utf-8" > >Changed two lines similar to: > unless (C4::Context->config('demo') == 1) { >into lines similar to: > unless (C4::Context->config('demo')) { >By removing the == 1, undefined = false without an error. The >value of demo is supposedly set by a koha-conf.xml variable, >but there is very little documentation on this "demo mode" >beyond the set it to 1 in koha conf for demo mode. Also, demo >doesn't exist in the default koha-conf.xml file generated. >So anyone who knows to create it, will likely create it the >proper way and with the proper value. >--- > admin/marctagstructure.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl >index fd8d7c2..0326b93 100755 >--- a/admin/marctagstructure.pl >+++ b/admin/marctagstructure.pl >@@ -149,7 +149,7 @@ if ($op eq 'add_form') { > my $repeatable = $input->param('repeatable') ? 1 : 0; > my $mandatory = $input->param('mandatory') ? 1 : 0; > my $authorised_value = $input->param('authorised_value'); >- unless (C4::Context->config('demo') == 1) { >+ unless (C4::Context->config('demo')) { > if ($input->param('modif')) { > $sth = $dbh->prepare( > "UPDATE marc_tag_structure SET liblibrarian=? ,libopac=? ,repeatable=? ,mandatory=? ,authorised_value=? WHERE frameworkcode=? AND tagfield=?" >@@ -194,7 +194,7 @@ if ($op eq 'add_form') { > ################## DELETE_CONFIRMED ################################## > # called by delete_confirm, used to effectively confirm deletion of data in DB > } elsif ($op eq 'delete_confirmed') { >- unless (C4::Context->config('demo') == 1) { >+ unless (C4::Context->config('demo')) { > my $sth1 = $dbh->prepare("DELETE FROM marc_tag_structure WHERE tagfield=? AND frameworkcode=?"); > my $sth2 = $dbh->prepare("DELETE FROM marc_subfield_structure WHERE tagfield=? AND frameworkcode=?"); > $sth1->execute($searchfield, $frameworkcode); >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8849
:
12616
|
12674
|
12707
|
12718